-
Notifications
You must be signed in to change notification settings - Fork 9
Import channel implementations from Python SDK v0.9.0 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import channel implementations from Python SDK v0.9.0 #3
Conversation
leandro-lucarella-frequenz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't go through the code as it was imported, only looked at the supporting/tooling files.
I would also remove the extra channels sub-directory in both benchmarks/ and tests/, as channels should be the only package provided by this repo.
Only the comment about py.typed is important to at least check if it is working. The rest are minor, so approving.
Signed-off-by: Sahas Subramanian <[email protected]>
19f1a1d to
f6dfeea
Compare
this is also done. |
|
BTW, I'm trying to adopt a convention for "conversations" and using the 🚀 emoji to indicate for me we can resolve the conversation. I'm using it when I have a final comment because if I resolve it, then other people usually miss the comment because the conversation is collapsed. So if you see any conversations where my last message has a 🚀 emoji, feel free to mark it as resolved. If I don't have no further comments I will just resolve the conversations I started myself when whatever it was about is resolved. |
|
That's a nice idea 🚀 |
No description provided.