Fix timer reset() while it is being waited on
#241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
part:docs
Contributor
Author
|
Based on #240. The test is flaky, I will update it to remove the flakiness. |
llucax
force-pushed
the
fix-timer-reset
branch
from
da1fed6 to
140499b
Compare
Contributor
Author
|
Updated, hopefully this time it passes all the tests. |
llucax
force-pushed
the
fix-timer-reset
branch
from
140499b to
336c437
Compare
Contributor
Author
|
#240 merged, rebased. |
Contributor
Author
|
Enabled auto-merge, please don't approve if you have suggestions. |
Contributor
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
There was a problem hiding this comment.
I have a couple of suggestions to check for. LGTM otherwise
llucax
force-pushed
the
fix-timer-reset
branch
from
336c437 to
b37aa52
Compare
Contributor
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
There was a problem hiding this comment.
Just have a question about the missing copyright/license header in the test
llucax
force-pushed
the
fix-timer-reset
branch
from
b37aa52 to
b6ccfcc
Compare
llucax
force-pushed
the
fix-timer-reset
branch
from
b6ccfcc to
886ed11
Compare
tests/test_timer_integration.py
Outdated
| @@ -0,0 +1,34 @@ | |||
| # License: MIT | |||
| # Copyright © 2022 Frequenz Energy-as-a-Service GmbH | |||
Contributor
There was a problem hiding this comment.
Suggested change
| # Copyright © 2022 Frequenz Energy-as-a-Service GmbH | |
| # Copyright © 2023 Frequenz Energy-as-a-Service GmbH |
This test needs to be an integration test because async-solipsism would make any sleep return immediately, so we wouldn't have a way to do the reset while the timer is being waited on. Signed-off-by: Leandro Lucarella <[email protected]>
If the timer was reset while it was being waited on, the next tick time was not recalculated and the timer would wait for the original time instead of the new one. Signed-off-by: Leandro Lucarella <[email protected]>
Signed-off-by: Leandro Lucarella <[email protected]>
llucax
force-pushed
the
fix-timer-reset
branch
from
886ed11 to
878ba9b
Compare
daniel-zullo-frequenz
approved these changes
Nov 22, 2023
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the timer was reset while it was being waited on, the next tick time was not recalculated and the timer would wait for the original time instead of the new one.
This means a timeout could fire even if there was actually no timeout (because the timer was reset).