Skip to content

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Oct 8, 2025

Remove --experimental-oracles CLI flag and experimental warnings from oracles feature

All changes completed and verified:

  • Remove --experimental-oracles CLI flag from TestArgs in crates/forge/src/lib.rs
  • Remove experimental warnings from documentation in docs/src/snforge-advanced-features/oracles.md
  • Remove CLI flag documentation section in docs/src/appendix/snforge/test.md
  • Remove experimental check in runtime extension in crates/cheatnet/src/runtime_extensions/forge_runtime_extension/mod.rs
  • Remove experimental_oracles field from ForgeExtension struct and make oracles always enabled
  • Remove experimental_oracles field from TestRunnerConfig in crates/forge-runner/src/forge_config.rs
  • Remove experimental_oracles field from RuntimeConfig in crates/forge-runner/src/forge_config.rs
  • Update combine_configs function in crates/forge/src/combine_configs.rs
  • Update test code that sets experimental_oracles: false to remove the field
  • Add entry to CHANGELOG.md Unreleased section only (without modifying any released versions)
  • Build and test changes to ensure nothing breaks

Verification Results:

  • ✅ All modified crates compile successfully
  • ✅ Unit tests pass (combine_configs, forge_runner, cheatnet)
  • ✅ Binary builds successfully
  • ✅ CLI help output confirmed flag is removed
  • ✅ No remaining references to experimental oracle flags
  • ✅ CHANGELOG properly updated: new entry in Unreleased section, released versions unchanged

Summary:
The oracle feature is now stable and always enabled. Users no longer need to pass --experimental-oracles flag or set SNFORGE_EXPERIMENTAL_ORACLES environment variable. All experimental warnings have been removed from documentation.

Original prompt

Oracles are becoming stable. Remove --experimental-oracle CLI flag everywhere (including documentation) and any mentions telling that oracles are experimental.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] Remove experimental oracle flag from all instances Remove experimental oracles flag - oracles are now stable Oct 8, 2025
@Copilot Copilot AI requested a review from mkaput October 8, 2025 10:03
Copilot finished work on behalf of mkaput October 8, 2025 10:03
@Copilot Copilot AI requested a review from mkaput October 8, 2025 10:47
Copilot finished work on behalf of mkaput October 8, 2025 10:47
@mkaput mkaput marked this pull request as ready for review October 8, 2025 10:50
@mkaput mkaput requested a review from a team as a code owner October 8, 2025 10:50
@mkaput mkaput requested review from MKowalski8 and cptartur October 8, 2025 10:50
@mkaput mkaput enabled auto-merge October 8, 2025 11:45
Copilot finished work on behalf of cptartur October 9, 2025 09:34
@Copilot Copilot AI requested a review from cptartur October 9, 2025 09:34
@mkaput mkaput added this pull request to the merge queue Oct 10, 2025
Merged via the queue into master with commit a668014 Oct 10, 2025
25 checks passed
@mkaput mkaput deleted the copilot/remove-experimental-oracle-flag branch October 10, 2025 09:05
cptartur added a commit that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants