Skip to content

Support devnet in --network flag #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Oct 15, 2025
Merged

Support devnet in --network flag #3786

merged 37 commits into from
Oct 15, 2025

Conversation

MKowalski8
Copy link
Member

@MKowalski8 MKowalski8 commented Oct 3, 2025 •
edited
Loading

Closes #3764

Introduced changes

  • Implement devnet detection for --network flag

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added relevant tests
  • Performed self-review of the code
  • Added changes to CHANGELOG.md

@MKowalski8 MKowalski8 changed the title 3764 support devnet via network flag Support devnet in --network flag Oct 3, 2025
@MKowalski8 MKowalski8 marked this pull request as ready for review October 7, 2025 09:40
@MKowalski8 MKowalski8 requested a review from a team as a code owner October 7, 2025 09:40
franciszekjob
franciszekjob requested changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once 3603-3-devnet-interactions-docs is merged, let's mention ability to use --network devnet in the docs 👍 .

MKowalski8
MKowalski8 commented Oct 7, 2025
View reviewed changes
cptartur
cptartur reviewed Oct 7, 2025
View reviewed changes
franciszekjob
franciszekjob reviewed Oct 7, 2025
View reviewed changes
MKowalski8
MKowalski8 commented Oct 10, 2025
View reviewed changes
franciszekjob
franciszekjob approved these changes Oct 13, 2025
View reviewed changes
cptartur
cptartur reviewed Oct 13, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left some additional comments

@MKowalski8 MKowalski8 requested a review from cptartur October 14, 2025 09:12
cptartur
cptartur reviewed Oct 14, 2025
View reviewed changes
Copy link
Member

@cptartur cptartur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment about splitting up the file, otherwise looks good

@MKowalski8 MKowalski8 requested a review from cptartur October 14, 2025 14:20
@MKowalski8 MKowalski8 added this pull request to the merge queue Oct 15, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025
@MKowalski8 MKowalski8 added this pull request to the merge queue Oct 15, 2025
Merged via the queue into master with commit df0c7ed Oct 15, 2025
47 of 48 checks passed
@MKowalski8 MKowalski8 deleted the 3764-support-devnet-via-network-flag branch October 15, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@franciszekjob franciszekjob franciszekjob approved these changes

@cptartur cptartur cptartur approved these changes

@ddoktorski ddoktorski Awaiting requested review from ddoktorski ddoktorski is a code owner automatically assigned from foundry-rs/starknet-foundry

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support devnet in --network flag

3 participants

@MKowalski8 @cptartur @franciszekjob