Skip to content

Allow declaring with deployment #3783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 13, 2025
Merged

Allow declaring with deployment #3783

merged 5 commits into from
Oct 13, 2025

Conversation

cptartur
Copy link
Member

@cptartur cptartur commented Oct 3, 2025 •
edited
Loading

commit-id:82e786a7

Conflicts:

crates/sncast/src/main.rs

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Oct 3, 2025
Closed
Closed
Closed
Closed
@cptartur cptartur marked this pull request as ready for review October 3, 2025 10:54
@cptartur cptartur requested a review from a team as a code owner October 3, 2025 10:54
@cptartur cptartur requested review from ddoktorski and franciszekjob and removed request for a team October 3, 2025 10:54
@cptartur cptartur force-pushed the spr/master/82e786a7 branch 2 times, most recently from ac92c0d to 48c85d9 Compare October 3, 2025 14:23
@cptartur cptartur force-pushed the spr/master/94945a36 branch from 899b363 to a9c96f6 Compare October 3, 2025 14:23
franciszekjob
franciszekjob reviewed Oct 3, 2025
View reviewed changes
@cptartur cptartur force-pushed the spr/master/82e786a7 branch from 48c85d9 to 859e21b Compare October 6, 2025 11:43
@cptartur cptartur force-pushed the spr/master/94945a36 branch from a9c96f6 to 41b8753 Compare October 6, 2025 11:43
@cptartur cptartur requested a review from franciszekjob October 6, 2025 11:46
@cptartur cptartur force-pushed the spr/master/94945a36 branch from 41b8753 to 39b967c Compare October 6, 2025 13:14
@cptartur cptartur force-pushed the spr/master/82e786a7 branch 2 times, most recently from 28cef8c to b764071 Compare October 6, 2025 13:29
franciszekjob
franciszekjob reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about mentioning this in sncast 101?

@cptartur cptartur force-pushed the spr/master/82e786a7 branch from b764071 to 96a6140 Compare October 6, 2025 14:47
@cptartur cptartur force-pushed the spr/master/94945a36 branch from 39b967c to 0b18bd5 Compare October 6, 2025 14:47
@cptartur cptartur force-pushed the spr/master/82e786a7 branch from 96a6140 to 24199f7 Compare October 7, 2025 12:52
@cptartur cptartur force-pushed the spr/master/94945a36 branch from 0b18bd5 to 04e89a1 Compare October 7, 2025 12:52
@cptartur cptartur requested a review from franciszekjob October 7, 2025 12:52
@cptartur cptartur force-pushed the spr/master/94945a36 branch from 04e89a1 to 5ea3fa5 Compare October 7, 2025 14:39
@cptartur cptartur force-pushed the spr/master/82e786a7 branch from 24199f7 to aaa6e8d Compare October 7, 2025 14:39
@cptartur cptartur linked an issue Oct 7, 2025 that may be closed by this pull request
Implement declare-deploy command in cast #3606
Closed
franciszekjob
franciszekjob approved these changes Oct 7, 2025
View reviewed changes
ddoktorski
ddoktorski reviewed Oct 7, 2025
View reviewed changes
@cptartur cptartur force-pushed the spr/master/94945a36 branch from 5ea3fa5 to 50056c1 Compare October 8, 2025 10:42
@cptartur cptartur force-pushed the spr/master/82e786a7 branch from aaa6e8d to 68b7ff7 Compare October 8, 2025 10:43
@cptartur cptartur requested a review from ddoktorski October 8, 2025 10:43
ddoktorski
ddoktorski reviewed Oct 8, 2025
View reviewed changes
Copy link
Contributor

@ddoktorski ddoktorski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog should be also updated

@cptartur cptartur force-pushed the spr/master/94945a36 branch from 50056c1 to a4892e3 Compare October 9, 2025 09:48
@cptartur cptartur force-pushed the spr/master/82e786a7 branch 2 times, most recently from 308507e to ad01518 Compare October 9, 2025 09:55
@cptartur cptartur requested a review from ddoktorski October 9, 2025 14:34
ddoktorski
ddoktorski reviewed Oct 10, 2025
View reviewed changes
@cptartur
Handle redeclaration in estimate fee, closes #3253
3e9de1b 
commit-id:f3897b34
@cptartur
Remove unused response structs
33f5deb 
commit-id:fcef8826

# Conflicts:
#	crates/sncast/src/response/declare.rs
@cptartur
Change declare arguments
8355469 
commit-id:e1eef354
@cptartur
Allow disabling printing in wait_for_tx
fdf330c 
commit-id:94945a36
@cptartur
Allow declaring with deployment
bffca92 
commit-id:82e786a7

# Conflicts:
#	crates/sncast/src/main.rs
@cptartur cptartur force-pushed the spr/master/82e786a7 branch from ad01518 to bffca92 Compare October 13, 2025 09:38
@cptartur cptartur force-pushed the spr/master/94945a36 branch from a4892e3 to fdf330c Compare October 13, 2025 09:38
@cptartur cptartur requested a review from ddoktorski October 13, 2025 09:39
@cptartur cptartur changed the base branch from spr/master/94945a36 to master October 13, 2025 10:37
@cptartur cptartur enabled auto-merge October 13, 2025 10:37
@cptartur cptartur added this pull request to the merge queue Oct 13, 2025
@cptartur cptartur linked an issue Oct 13, 2025 that may be closed by this pull request
Improve error message when trying to redeclare contract using sncast declare #3253
Closed
Merged via the queue into master with commit 5409ba6 Oct 13, 2025
24 of 44 checks passed
@cptartur cptartur deleted the spr/master/82e786a7 branch October 13, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ddoktorski ddoktorski ddoktorski approved these changes

@franciszekjob franciszekjob franciszekjob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement declare-deploy command in cast Improve error message when trying to redeclare contract using sncast declare

3 participants

@cptartur @ddoktorski @franciszekjob