feat: transaction access list option #8818
Conversation
crates/cli/src/utils/mod.rs
Outdated
| } | ||
|
|
||
| // Parses a `AccessList` from a &str | ||
| pub fn parse_access_list(s: &str) -> Result<AccessList> { |
There was a problem hiding this comment.
hmm, I am wondering if we should add some additional formats for better UX here? eg fallback to comma-separated addresses list or something similar
There was a problem hiding this comment.
@minhd-vu let's make access_list arg an Option<Option<String>> and if just --access-list with no value is provided, we'll use provider.create_access_list to create it through RPC
I think this would be pretty useful and would allow us to keep a way to invoke it without manually providing JSON access list
There was a problem hiding this comment.
I like that idea, I'll try my best to implement it.
crates/cast/bin/tx.rs
Outdated
| tx.set_nonce(nonce.to()); | ||
| } | ||
|
|
||
| if let Some(access_list) = match tx_opts.access_list { |
There was a problem hiding this comment.
we should do it right before estimating gas in _build
we don't yet have calldata here, so calling rpc will result in incomplete data or an error
* add access list * fix lint * improve * set access list even if legacy is true * update grammar * update comment to doc string * call access list if no string provided * address comments * update docs * update docs again * address comments * refactor
3 participants
Motivation
cast sendorcast mktx, it would be nice to be able to provide an access listSolution
--access-listflag for transactions--access-listprovided with no value will usecast access-listto populate the access list