change pretty-calldata labels from decimal ints to hex values #4487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the labels on pretty-calldata from decimal integers to hex labels, like one finds in the debugger.
For example,
becomes
Motivation
The integer labels require mental energy to convert to hex, which is how my team typically thinks of these. Converting to hex saves time and mental energy.
Solution
I updated the display method for
PossibleSigs
.NOTE: This is my first time writing rust and my first time making this type of contribution. I read the contribution guidelines and attempted to follow their instructions, but I found some of the cargo checks hard to parse. I skipped opening an issue since the change is tiny and cosmetic. Please let me know what I need to do to properly comply with the letter and spirit of the contribution rules.
EDIT: This change also makes it easier to look up offsets.