fix: address false positive #2914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can we maybe add some unit tests over to |
gakonst
reviewed
Aug 24, 2022
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
@odyslam can we add a test here for this case? https://github.com/foundry-rs/foundry/blob/master/testdata/cheats/Parse.t.sol
Contributor
Author
gakonst
approved these changes
Aug 25, 2022
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
* fix: address false positive * fix: refactor for unstable warning * fix: correct encoding of null values * chore: add test for non-address H160 * fix: correct use-case to be string, not bytes * chore: forge fmt Co-authored-by: Georgios Konstantopoulos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It detected the following string as address (as it could convert it to H160)
0000000000000000000000000000000000001337
EDIT: Included another fix for null values