feat: cast mktx raw signaturee #10377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayushdubey86
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy,
yash-atreya and
zerosnacks
as code owners
mattsse
requested changes
May 16, 2025
Comment on lines
+55
to
+62
| #[arg(long, value_name = "V")] | ||
| v: Option<u64>, | ||
|
|
||
| #[arg(long, value_name = "R")] | ||
| r: Option<String>, | ||
|
|
||
| #[arg(long, value_name = "S")] | ||
| s: Option<String>, |
There was a problem hiding this comment.
this should be a single argument that tis the hex encoded signature
Comment on lines
+130
to
+161
| let raw_unsigned_hex = tx_builder.build_unsigned_raw(from).await?; | ||
|
|
||
| if let (Some(v), Some(r_hex), Some(s_hex)) = (v, r.as_ref(), s.as_ref()) { | ||
| let raw_unsigned_bytes = hex::decode(raw_unsigned_hex.trim_start_matches("0x"))?; | ||
| let mut buf = raw_unsigned_bytes.as_slice(); | ||
| let unsigned_tx: UnsignedTransaction = UnsignedTransaction::decode(&mut buf)?; | ||
|
|
||
| let r_bytes = hex::decode(r_hex.trim_start_matches("0x"))?; | ||
| let s_bytes = hex::decode(s_hex.trim_start_matches("0x"))?; | ||
|
|
||
| if r_bytes.len() != 32 || s_bytes.len() != 32 { | ||
| eyre::bail!("r and s must be 32 bytes each"); | ||
| } | ||
|
|
||
| let r = U256::from_be_slice(&r_bytes); | ||
| let s = U256::from_be_slice(&s_bytes); | ||
| let v = U64::from(v); | ||
|
|
||
| let mut out = Vec::new(); | ||
| let fields: &[&dyn alloy_rlp::Encodable] = &[ | ||
| &unsigned_tx.nonce, | ||
| &unsigned_tx.gas_price, | ||
| &unsigned_tx.gas_limit, | ||
| &unsigned_tx.to, | ||
| &unsigned_tx.value, | ||
| &unsigned_tx.data, | ||
| &v, | ||
| &r, | ||
| &s, | ||
| ]; | ||
|
|
||
| alloy_rlp::encode_list::<&dyn alloy_rlp::Encodable, dyn alloy_rlp::Encodable>( |
There was a problem hiding this comment.
this can removed entirely
this should be much simpler, just checking if the signature is there , decode it and then encode with signature:
|
Closing as stale. Feel free to re-open or open a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @yash-atreya @zerosnacks @grandizzy
Please review this pr, it closes #10167