Skip to content

Corrects various dredd hooks #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 9, 2019
Merged

Corrects various dredd hooks #5486

merged 2 commits into from
Jan 9, 2019

Conversation

@prabhupant
Copy link
Contributor

@prabhupant prabhupant commented Dec 22, 2018

Fixes #5485

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream development branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

use of correct factories

Changes proposed in this pull request:

  • use of correct factories

houndci-bot
houndci-bot reviewed Dec 22, 2018
View reviewed changes
@prabhupant prabhupant force-pushed the corrects-dredd-hooks branch 3 times, most recently from 363be99 to e83861c Compare December 22, 2018 14:44
iamareebjamal
iamareebjamal requested changes Dec 22, 2018
View reviewed changes
Copy link
Member

@iamareebjamal iamareebjamal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failing

@prabhupant
Copy link
Contributor Author

prabhupant commented Dec 22, 2018

@iamareebjamal please help me with what is failing? it's saying 'speakers calls' doesn't have link attribute

@prabhupant prabhupant force-pushed the corrects-dredd-hooks branch 4 times, most recently from 6645a0c to 6dda137 Compare December 28, 2018 08:50
@prabhupant prabhupant force-pushed the corrects-dredd-hooks branch from 5a2826b to 76e1567 Compare January 6, 2019 12:38
@prabhupant prabhupant force-pushed the corrects-dredd-hooks branch from 7e55fc7 to 28ae869 Compare January 8, 2019 16:44
@prabhupant
Copy link
Contributor Author

prabhupant commented Jan 8, 2019

@iamareebjamal please review :)

@dr0pdb dr0pdb merged commit b4f5ee0 into fossasia:development Jan 9, 2019
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
@prabhupant @mrsaicharan1
test: Correct various dredd hooks and minor typos (fossasia#5486)
bc23c32
mrsaicharan1 pushed a commit to mrsaicharan1/open-event-server that referenced this pull request Jan 30, 2019
@prabhupant @mrsaicharan1
test: Correct various dredd hooks and minor typos (fossasia#5486)
965ca58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

+2 more reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@dr0pdb dr0pdb dr0pdb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modifications in dredd hooks

4 participants

@prabhupant @iamareebjamal @houndci-bot @dr0pdb