Skip to content

feat: add telegram & gitter social links #5069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamareebjamal merged 2 commits into from
Sep 16, 2020
Merged

feat: add telegram & gitter social links #5069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e30762
add telegram & gitter social links
progmatic-99 Sep 14, 2020
03f77aa
Add segmented urls
progmatic-99 Sep 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/models/setting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ export default ModelBase.extend({
facebookUrl : attr('string'),
instagramUrl : attr('string'),
patreonUrl : attr('string'),
gitterUrl : attr('string'),
telegramUrl : attr('string'),
youtubeUrl : attr('string'),
androidAppUrl : attr('string'),
frontendUrl : attr('string'),
Expand Down Expand Up @@ -106,6 +108,8 @@ export default ModelBase.extend({
segmentedFacebookUrl : computedSegmentedLink.bind(this)('facebookUrl'),
segmentedInstagramUrl : computedSegmentedLink.bind(this)('instagramUrl'),
segmentedPatreonUrl : computedSegmentedLink.bind(this)('patreonUrl'),
segmentedGitterUrl : computedSegmentedLink.bind(this)('gitterUrl'),
segmentedTelegramUrl : computedSegmentedLink.bind(this)('telegramUrl'),
Copy link
Member

@iamareebjamal iamareebjamal Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add them below

segmentedTwitterUrl : computedSegmentedLink.bind(this)('twitterUrl'),
segmentedGoogleUrl : computedSegmentedLink.bind(this)('googleUrl'),
segmentedYoutubeUrl : computedSegmentedLink.bind(this)('youtubeUrl'),
Expand Down
10 changes: 10 additions & 0 deletions app/templates/components/footer-main.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,16 @@
<i class="patreon icon"></i> {{t 'Patreon'}}
</a>
{{/if}}
{{#if this.socialLinks.gitterUrl}}
<a class="item" href="{{this.socialLinks.gitterUrl}}" target="_blank" rel="noopener noreferrer">
<i class="gitter icon"></i> {{t 'Gitter'}}
</a>
{{/if}}
{{#if this.socialLinks.telegramUrl}}
<a class="item" href="{{this.socialLinks.telegramUrl}}" target="_blank" rel="noopener noreferrer">
<i class="telegram icon"></i> {{t 'Telegram'}}
</a>
{{/if}}
</div>
</div>
</div>
Expand Down
16 changes: 16 additions & 0 deletions app/templates/components/forms/admin/content/social-links-form.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,21 @@
@isSocialLink={{true}}
@inputId="patreon" />
</div>
<div class="field">
<label>{{t 'Gitter'}}</label>
<Widgets::Forms::LinkInput
@segmentedLink={{this.socials.segmentedGitterUrl}}
Copy link
Member

@iamareebjamal iamareebjamal Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist

Copy link
Contributor Author

@progmatic-99 progmatic-99 Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?
Is it not appearing on the front-end ?

Copy link
Member

@iamareebjamal iamareebjamal Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

segmentedGitterUrl does not exist

@linkName="gitter"
@isSocialLink={{true}}
@inputId="gitter" />
</div>
<div class="field">
<label>{{t 'Telegram'}}</label>
<Widgets::Forms::LinkInput
@segmentedLink={{this.socials.segmentedTelegramUrl}}
Copy link
Member

@iamareebjamal iamareebjamal Sep 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not exist

@linkName="telegram"
@isSocialLink={{true}}
@inputId="telegram" />
</div>
<button class="ui teal button" type="submit">{{t 'Save'}}</button>
</form>