Skip to content

Changed filenames #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2021
Merged

Changed filenames #388

merged 2 commits into from
Apr 17, 2021

Conversation

wclodius2
Copy link
Contributor

Changed filenames in test_stdlib_bitsets_64.f90 and test_stdlib_bitsets_large.f90 so that they were no longer the same. Also removed spurious blanks in error stops.

[ticket: X]

Changed filenames in test_stdlib_bitsets_64.f90 and test_stdlib_bitsets_large.f90 so that they were no longer the same. Also removed spurious blanks in error stops.

[ticket: X]
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would open with status='scratch' and rewind(unit) instead of closing and reopening a named file here work better?

@wclodius2
Copy link
Contributor Author

wclodius2 commented Apr 12, 2021 via email

Changed the input/output files to scratch files to eliminate I/O interactions
between the two programs, and the generated file clutter.

[ticket: X]
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@awvwgk awvwgk added the reviewers needed This patch requires extra eyes label Apr 17, 2021
Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LKedward LKedward linked an issue Apr 17, 2021 that may be closed by this pull request
@awvwgk awvwgk removed the reviewers needed This patch requires extra eyes label Apr 17, 2021
@awvwgk awvwgk merged commit df514c9 into fortran-lang:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erratic failure of in-tree build for stdlib_bitset_64
3 participants