Fixes update intrinsics action #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #362 +/- ##
=======================================
Coverage 87.52% 87.52%
=======================================
Files 35 35
Lines 4760 4760
=======================================
Hits 4166 4166
Misses 594 594 ☔ View full report in Codecov by Sentry. |
gnikit
requested changes
Mar 18, 2024
Member
gnikit
left a comment
gnikit
left a comment
There was a problem hiding this comment.
Nice work, I think you should be using Path since the directories now are rather nested.
gnikit
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes update instrinsics action #358 after updating the file paths according to new architecture. Tested the workflow by manually triggering it,works fine.