fix: evaluates langid only at LSP creation #279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do a lazy evaluation of the `langid`, only replacing it with a value at the LSP creation stage. This allows us to better isolate the LSP and the AST parts of the server. Fixes #257
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
+ Coverage 86.91% 86.94% +0.02%
==========================================
Files 12 12
Lines 4556 4566 +10
==========================================
+ Hits 3960 3970 +10
Misses 596 596
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do a lazy evaluation of the
langid, onlyreplacing it with a value at the LSP creation stage.
This allows us to better isolate the LSP
and the AST parts of the server.
Fixes #257