Remove set_time_limit(300);

[guitarbeard]

This is blocking the export of large databases. The application should use php.ini to set the time limit and not magic numbers hidden in code here: https://github.com/formtools/module-export_manager/blob/master/code/Module.class.php#L597

[benkeen]

Hey @guitarbeard, thanks! Good idea. The problem is that some systems have very low settings for that var, so the setting here was intended to mitigate that.

But what we need is probably a setting in the UI. Perhaps even a Form Tools core setting, rather than something specific to this module.

[benkeen]

Also see: formtools/core#636

[benkeen]

I ended up making it just configurable within the module rather than with the main script. I figure it's possible you'd want different timeouts for different activities. I'll release 3.2.0 now.

[guitarbeard]

Awesome! Glad I could help out and thank you for all the work you do!

…

On Sat, Nov 9, 2019 at 11:46 AM Ben Keen ***@***.***> wrote: I ended up making it just configurable within the module rather than with the main script. I figure it's possible you'd want different timeouts for different activities. I'll release 3.2.0 now. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#26?email_source=notifications&email_token=AAVX7BQOIJLFKXRKIGUNK53QS4HRVA5CNFSM4JJODOH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDUNUGI#issuecomment-552131097>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAVX7BWCSLMA44G3DM3B6BTQS4HRVANCNFSM4JJODOHQ> .