Add Support for SAS keys in Azure Blob #738
Conversation
stefanprodan
added
area/bucket
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
8b4c399 to
a92403f
Compare
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
A few nits. And I think we need some safeguards to ensure SAS tokens would leak into errors.
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
94a5342 to
7182c56
Compare
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
7182c56 to
0670db7
Compare
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
b2f0826 to
c3eabe2
Compare
pjbgf
left a comment
pjbgf
left a comment
There was a problem hiding this comment.
LGTM
thanks for getting this implemented @somtochiama! 🙇♂️
|
@somtochiama do you mind rebasing please? |
docs/spec/v1beta2/buckets.md
Outdated
| The query values from the `sasKey` data field in the Secrets gets merged with the `spec.endpoint` of the `Bucket`. | ||
| If the same key is present in the both of them, the token takes precedence. |
There was a problem hiding this comment.
I feel this could use more explanation. In combination with looking at the doc page of the added ref, I had at least the following questions:
-
Does the
sasKeyonly contain the "SAS token"? -
If so, is it expected to be prefixed with
?as suggested in the documentation? -
What does
If the same key is present in the both of them, the token takes precedence.
entail precisely?
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
dfc4ac6 to
044b8c3
Compare
Signed-off-by: Somtochi Onyekwere <[email protected]>
somtochiama
force-pushed
the
sas-key-azure-blob
branch
from
044b8c3 to
3526863
Compare
|
@somtochiama thank you for addressing @hiddeco 's point. Can you rebase please? |
4 participants
This pull request adds support for SAS Keys in Azure Blob.
The SAS token is specified in the secret under
sasKeyfield.Fixes: #719
Signed-off-by: Somtochi Onyekwere [email protected]