Refactor Fuzz implementation #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AdamKorcz <[email protected]>
hiddeco
reviewed
Jan 14, 2022
controllers/suite_test.go
Outdated
| MetricsRecorder: testMetricsH.MetricsRecorder, | ||
| } | ||
| if err := (reconciler).SetupWithManager(testEnv, KustomizationReconcilerOptions{MaxConcurrentReconciles: 4}); err != nil { | ||
| panic(fmt.Sprintf("Failed to start GitRepositoryReconciler: %v", err)) |
There was a problem hiding this comment.
Suggested change
| panic(fmt.Sprintf("Failed to start GitRepositoryReconciler: %v", err)) | |
| panic(fmt.Sprintf("Failed to start KustomizationReconciler: %v", err)) |
Structure the fuzz implementation to be closer to what go native will support. Add Makefile target to enable smoketesting fuzzers. Add smoketest as CI workflow. Signed-off-by: Paulo Gomes <[email protected]>
This was referenced Jan 19, 2022
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following-up from the security audit, I reviewed the initial Fuzz PR and created this PR that supersedes it.
Main changes: