Update source-controller with libgit2 race fixes #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
force-pushed
the
use-libgit2-ssh-race-fixes
branch
5 times, most recently
from
0f45f04 to
2cbccbb
Compare
darkowlzz
force-pushed
the
use-libgit2-ssh-race-fixes
branch
3 times, most recently
from
730932f to
a4d9310
Compare
darkowlzz
changed the title
hiddeco
approved these changes
Jun 2, 2022
Also, removes the panic recovery code added in cloneInto() as the underlying Checkout() in SC already has a panic handler. The issues were due to goroutine panicking, which are now handled in the SC libgit managed transport. Signed-off-by: Sunny <[email protected]>
darkowlzz
force-pushed
the
use-libgit2-ssh-race-fixes
branch
from
a4d9310 to
9e56084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update source-controller with libgit2 race fixes.
Also, removes the panic recovery code added in cloneInto() as the
underlying Checkout() in SC already has a panic handler. The issues were
due to goroutine panicking, which are now handled in the SC libgit
managed transport.