Change RenderBinding to SemanticsBinding #8846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsansone
added
review.copy
sfshaza2
reviewed
Jun 8, 2023
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
Really? I don't feel that this text is any better. In fact, it would be best if it linked to the API doc.
atsansone
commented
Jun 8, 2023
Contributor
Author
atsansone
left a comment
atsansone
left a comment
There was a problem hiding this comment.
It only changed the outdated code. We could change it to a link, but not sure it's worth sending folks elsewhere for one line of code.
Contributor
|
There's still some details missing about how to use a SemanticsHandle once you get an instance of it, for example, calling |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8686