Skip to content

Conversation

@sfshaza2
Copy link
Contributor

@sfshaza2 sfshaza2 commented Dec 3, 2025

Fixes #12641. Adds a glossary entry for 'Engine' to src/data/glossary.yml.

@sfshaza2 sfshaza2 requested a review from a team as a code owner December 3, 2025 23:58
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sfshaza2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new glossary entry for 'Engine' to enrich the documentation. Concurrently, it refines the behavior of expandable cards across the site, specifically for glossary entries. The changes ensure that all glossary cards are initially collapsed by default, while also providing functionality to automatically expand a specific card if its ID is present in the URL fragment, thereby improving user navigation and overall experience.

Highlights

  • New Glossary Entry: A new glossary entry for 'Engine' has been added to src/data/glossary.yml, providing detailed descriptions, related links, and relevant labels.
  • Expandable Card Behavior: The Card component now supports an initiallyExpanded property, allowing cards to be rendered in a collapsed state by default if not explicitly set to expanded.
  • Glossary Card Default State: All GlossaryCard instances are now configured to be initiallyExpanded: false, ensuring that glossary entries are collapsed by default when the page loads.
  • Fragment-Based Card Expansion: The client-side JavaScript logic has been updated to automatically expand a specific glossary card if its ID matches the current URL fragment, overriding the default collapsed state for targeted navigation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new glossary entry for 'Engine' and refactors the expandable card behavior to support direct linking to glossary terms. The changes are well-implemented across the Dart components and YAML data file. The new logic for handling expandable cards is a good improvement, making them collapsed by default and expanding them via JavaScript only when they are targeted in the URL fragment.

I have a couple of suggestions for improvement:

  • In site/lib/src/pages/glossary.dart, there's a minor accessibility issue with the initial state of the aria-expanded attribute for the expand/collapse button.
  • In src/data/glossary.yml, I've suggested adding a link to the 'Impeller' glossary term from the new 'Engine' entry to improve navigation.

@flutter-website-bot
Copy link
Collaborator

flutter-website-bot commented Dec 4, 2025

Visit the preview URL for this PR (updated for commit 66031db):

https://flutter-docs-prod--pr12780-engine-eowbtowk.web.app

@sfshaza2
Copy link
Contributor Author

sfshaza2 commented Dec 4, 2025

Thanks for your excellent feedback, @loic-sharma! Please check again.

@parlough parlough requested a review from loic-sharma December 5, 2025 11:51
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sfshaza2
Copy link
Contributor Author

sfshaza2 commented Dec 5, 2025

@parlough, Loic has approved. Can you give it a gander?

Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks :D

5. Responsible for asset resolution.
[framework]: /resources/architectural-overview#architectural-layers
[Impeller]: /resources/glossary/#impeller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[Impeller]: /resources/glossary/#impeller
[Impeller]: /resources/glossary#impeller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add glossary entry for "Engine"

4 participants