Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@sfanxiang
Copy link

Android implementation for flutter/flutter#16624.

@sfanxiang sfanxiang changed the title video_player: Add speed adjustment support for Android [video_player] Add speed adjustment support for Android Oct 18, 2018
@ened
Copy link
Contributor

ened commented Dec 8, 2018

@sfanxiang nice PR! Could you work on the formatting issues that prevent the PR from going green?

@sfanxiang
Copy link
Author

Turns out fd8ad8a did the formatting, and 3f8abcf bumped ExoPlayer to 2.9.1, so I rebased this patch.

Now CI complains:

> Could not find com.google.android.exoplayer:exoplayer-core:2.9.1.

@amirh
Copy link
Contributor

amirh commented Mar 29, 2019

Note for reviewer: #1400 seems to be doing the same.

@cbenhagen
Copy link
Contributor

@sfanxiang thank you for your contribution! Unfortunately the structure of the plugin has changed lately to support implementations on more platforms. Mainly the plugin was moved to a new subdirectory and now uses a common platform interface. Adapting your PR to the new structure should be straight forward. If you have questions please ask!

Please also make sure to include tests for the new functionality. It would also be great to add this to the iOS and web parts of the plugin.

@cbenhagen
Copy link
Contributor

Actually I think this could be closed in favor of #1400 which also includes the iOS part.

@sfanxiang
Copy link
Author

@cbenhagen Feel free to close this if you believe #1400 is more helpful.

@cbenhagen
Copy link
Contributor

I can not close it. But if you think your Android implementation is better then the one in #1400, you could also comment there to improve it. I know your PR was first. But in the end the only thing that counts is to have the best implementation with the most complete tests and documentation no?

@ditman
Copy link
Member

ditman commented Sep 26, 2020

Published video_player v0.11.0, which contains the playback speed feature!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants