-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[quick_actions]: Bump mockito-core from 3.2.4 to 4.6.1 in /packages/quick_actions/quick_actions_android/android #5899
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ac9837c to
fd4bffa
Compare
fd4bffa to
40c0b95
Compare
3179306 to
dd9c635
Compare
dd9c635 to
5f8d165
Compare
|
@dependabot rebase |
5f8d165 to
3db081d
Compare
|
Looks like this will need some test updates for Mockito changes. |
3db081d to
1decce1
Compare
|
test-exempt: dependency roll |
b47d8c1 to
85e9d43
Compare
Bumps [mockito-core](https://github.com/mockito/mockito) from 3.2.4 to 4.6.1. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v3.2.4...v4.6.1) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
85e9d43 to
29ac28d
Compare
…ackages/quick_actions/quick_actions_android/android/org.mockito-mockito-core-4.6.1
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the version bump removed.
| @@ -1,6 +1,11 @@ | |||
| ## 0.6.3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this only affects tests, which don't impact clients of the plugin, you can remove the version bump from the pubspec and just use NEXT here.
publishable may still flag it because of build.gradle, but since it's a testImplementation line that's a false positive that you can override with the label. (Currently it's not doing any line-level analysis of the diff, only looking at files. Eventually we should make it smarter.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I understand now. Ok thanks!
…packages/quick_actions/quick_actions_android/android (flutter/plugins#5899)
…uick_actions/quick_actions_android/android (flutter#5899)
…uick_actions/quick_actions_android/android (flutter#5899)
…uick_actions/quick_actions_android/android (flutter#5899)
Bumps mockito-core from 3.2.4 to 4.6.1.
Release notes
Sourced from mockito-core's releases.
... (truncated)
Commits
ff98622Restore behavior for mocks configured without strictness (#2659)1fbef57Bump groovy from 3.0.10 to 3.0.11 (#2660)c47c7ecBump core-ktx from 1.7.0 to 1.8.0 (#2661)2bbf796Bump material from 1.6.0 to 1.6.1 (#2662)4f41700Bump assertj-core from 3.22.0 to 3.23.1 (#2658)e5a06c5Fix typo (#2655)93bba11Bump shipkit-changelog from 1.1.15 to 1.2.0 (#2654)70cf2d2Add support for customizing strictness via@Mockannotation and `MockSettin...6ce278bBump versions.errorprone from 2.13.1 to 2.14.0 (#2653)7d2e4ccBump shipkit-auto-version from 1.1.20 to 1.2.0 (#2651)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)