Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Don't do reentrant message channel calls. #560

Merged
floitschG merged 1 commit into from
May 9, 2018
Merged

Don't do reentrant message channel calls. #560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 39 additions & 31 deletions packages/cloud_firestore/test/cloud_firestore_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,40 +42,48 @@ void main() {
switch (methodCall.method) {
case 'Query#addSnapshotListener':
final int handle = mockHandleId++;
BinaryMessages.handlePlatformMessage(
Firestore.channel.name,
Firestore.channel.codec.encodeMethodCall(
new MethodCall('QuerySnapshot', <String, dynamic>{
'app': app.name,
'handle': handle,
'paths': <String>["${methodCall.arguments['path']}/0"],
'documents': <dynamic>[kMockDocumentSnapshotData],
'documentChanges': <dynamic>[
<String, dynamic>{
'oldIndex': -1,
'newIndex': 0,
'type': 'DocumentChangeType.added',
'document': kMockDocumentSnapshotData,
},
],
}),
),
(_) {},
);
// Wait for a microtask before sending a message back.
// Otherwise the first request didn't have the time to finish.
scheduleMicrotask(() {
BinaryMessages.handlePlatformMessage(
Firestore.channel.name,
Firestore.channel.codec.encodeMethodCall(
new MethodCall('QuerySnapshot', <String, dynamic>{
'app': app.name,
'handle': handle,
'paths': <String>["${methodCall.arguments['path']}/0"],
'documents': <dynamic>[kMockDocumentSnapshotData],
'documentChanges': <dynamic>[
<String, dynamic>{
'oldIndex': -1,
'newIndex': 0,
'type': 'DocumentChangeType.added',
'document': kMockDocumentSnapshotData,
},
],
}),
),
(_) {},
);
});
return handle;
case 'Query#addDocumentListener':
final int handle = mockHandleId++;
BinaryMessages.handlePlatformMessage(
Firestore.channel.name,
Firestore.channel.codec.encodeMethodCall(
new MethodCall('DocumentSnapshot', <String, dynamic>{
'handle': handle,
'path': methodCall.arguments['path'],
'data': kMockDocumentSnapshotData,
}),
),
(_) {},
);
// Wait for a microtask before sending a message back.
// Otherwise the first request didn't have the time to finish.
scheduleMicrotask(() {
BinaryMessages.handlePlatformMessage(
Firestore.channel.name,
Firestore.channel.codec.encodeMethodCall(
new MethodCall('DocumentSnapshot', <String, dynamic>{
'handle': handle,
'path': methodCall.arguments['path'],
'data': kMockDocumentSnapshotData,
}),
),
(_) {},
);
});
return handle;
case 'Query#getDocuments':
return <String, dynamic>{
Expand Down