Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Fix for 2 bugs in the Video Player plugin #557

Merged
mravn-google merged 2 commits into from
May 11, 2018
Merged

Fix for 2 bugs in the Video Player plugin #557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057a07d
Fixed an issue with the video_player where a native IOS method call w…
quentinleguennec May 8, 2018
f5a24bc
Fixed a crash when the eventSink is called on a null object in the vi…
quentinleguennec May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .../video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,10 @@ public void onBufferingUpdate(MediaPlayer mediaPlayer, int percent) {
new MediaPlayer.OnErrorListener() {
@Override
public boolean onError(MediaPlayer mp, int what, int extra) {
eventSink.error(
"VideoError", "Video player had error " + what + " extra " + extra, null);
if (eventSink != null) {
eventSink.error(
"VideoError", "Video player had error " + what + " extra " + extra, null);
}
return true;
}
});
Expand Down
2 changes: 2 additions & 0 deletions packages/video_player/ios/Classes/VideoPlayerPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
[[_players objectForKey:textureId] dispose];
}
[_players removeAllObjects];
result(nil);
} else if ([@"create" isEqualToString:call.method]) {
NSDictionary* argsMap = call.arguments;
FLTFrameUpdater* frameUpdater = [[FLTFrameUpdater alloc] initWithRegistry:_registry];
Expand Down Expand Up @@ -327,6 +328,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
[_registry unregisterTexture:textureId];
[_players removeObjectForKey:@(textureId)];
[player dispose];
result(nil);
} else if ([@"setLooping" isEqualToString:call.method]) {
[player setIsLooping:[[argsMap objectForKey:@"looping"] boolValue]];
result(nil);
Expand Down