Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
a75185e
UI changes + adding dummy video button
nisdis Feb 13, 2018
137fe81
Added dummy Method call video() , with Hello World reply from iOS and…
nisdis Feb 14, 2018
5420d9b
UI changes
nisdis Feb 15, 2018
9fe57d0
Addition of some android MediaRecorder code
nisdis Feb 19, 2018
2db3927
Video recording enabled and running on Android with some bugs
nisdis Feb 20, 2018
2ef3348
Android: fixed bug that crashes app when switching cameras. Also chan…
nisdis Feb 28, 2018
13aea61
Android: fixed bug that crashes app when switching cameras. Also chan…
nisdis Feb 28, 2018
c1957cd
added comments and improved readability
nisdis Mar 7, 2018
f556d75
Updated GUIDE.md
nisdis Mar 7, 2018
dec4b19
Updated GUIDE.md
nisdis Mar 7, 2018
a1b41db
Updated GUIDE.md
nisdis Mar 7, 2018
006e0c5
Working code with iOS capture
nisdis Mar 14, 2018
6f3de6a
Working code with iOS capture
nisdis Mar 14, 2018
53b7873
Added comments and cleared unwanted code
nisdis Mar 15, 2018
4cdfd22
Video fix back to preview on iOS after capture is completed
nisdis Mar 19, 2018
4c1e76e
few changes plus rebase with master flutter/plugins repo
nisdis Mar 19, 2018
9d4614e
Addition of some android MediaRecorder code
nisdis Feb 19, 2018
f4fe896
added comments and improved readability
nisdis Mar 7, 2018
5fa0086
Big refactoring for the Dart and Android camera plugin. Handles error…
quentinleguennec Mar 12, 2018
2c089d9
Removed some auto-generated flutter logs. Fixed bugs in Android camer…
quentinleguennec Mar 15, 2018
dd75acc
Changes to the dart code to enable start/stop on iOS, now saves in do…
nisdis Mar 20, 2018
216513a
Adding description for the missing required permission description se…
luigi-agosti Mar 22, 2018
e30acd2
Merge remote-tracking branch 'upstream/master' into camera-dev
luigi-agosti Mar 22, 2018
465de48
Pr Fixes for bundle identifier in the example
luigi-agosti Mar 22, 2018
c5cb876
Removing commented code
luigi-agosti Mar 22, 2018
3798a0f
Removed start stop on flutter iOS and dummy calls on Android. Fixed p…
nisdis Mar 23, 2018
904cb8d
Merge branch 'camera-dev' of https://github.com/Tengio/plugins into c…
nisdis Mar 23, 2018
bde0f22
Fixing android camera permission crash
luigi-agosti Apr 5, 2018
3ea435a
Merged upstream changes
luigi-agosti Apr 5, 2018
97334a9
Reformatting and fixing pr issues
luigi-agosti Apr 5, 2018
e7458c7
CameraPlugin: Refactored error for event sink and removed debug logs.
quentinleguennec Apr 9, 2018
07d3e44
CameraPlugin: Refactored some names. Added documentation for some fun…
quentinleguennec Apr 10, 2018
383c1c3
Camera Plugin: Removed some unused code.
quentinleguennec Apr 10, 2018
e7f52e8
Reformatting code
luigi-agosti Apr 10, 2018
f71354e
Removing changes to xcode files, Fixing format of the android manifest
luigi-agosti Apr 11, 2018
7e63373
Removing unused persmission
luigi-agosti Apr 11, 2018
e88abeb
Removing intl and fixing pr issue
luigi-agosti Apr 11, 2018
7d20380
Add video preview to example
sigurdm Apr 11, 2018
d108be1
Remove debug prints
sigurdm Apr 11, 2018
8595213
Merge pull request #3 from sigurdm/video_preview
luigi-agosti Apr 11, 2018
cfa239d
Camera Plugin: various fixes based on PR comments.
quentinleguennec Apr 11, 2018
b182cc9
Camera Plugin: ran text formating.
quentinleguennec Apr 12, 2018
2be165e
Changes as suggested by the PR review.
holykou Apr 12, 2018
ee17048
Remove Message codec
holykou Apr 12, 2018
5d791cf
Removed file sharing key
holykou Apr 12, 2018
96011a4
EventSink syntax changed
holykou Apr 12, 2018
395c829
Error description key updated
holykou Apr 12, 2018
ecdbee2
Dart auto format
holykou Apr 12, 2018
aaa75ea
Camera Plugin: Refactored UI code of example app and improved it a li…
quentinleguennec Apr 12, 2018
9dfbb34
Merge pull request #4 from holykou/master
quentinleguennec Apr 12, 2018
d28a5f8
Merge pull request #5 from Tengio/ui-improvement
quentinleguennec Apr 12, 2018
47744a1
Camera Plugin: Replaced 'openCamera' with 'initialize' and 'closeCame…
quentinleguennec Apr 12, 2018
3acf493
Fixing aspect ratio for the video preview
luigi-agosti Apr 12, 2018
4222b58
Merge remote-tracking branch 'origin/master'
quentinleguennec Apr 17, 2018
4e0b8bd
PR changes for iOS.
holykou Apr 20, 2018
0c0597d
Crash prevention for AVAssetwriter
holykou Apr 20, 2018
14a09c2
Changed error description
holykou Apr 20, 2018
e759c42
Merge pull request #6 from holykou/master
luigi-agosti Apr 20, 2018
2762562
Camera Plugin: Fixed a few PR comments.
quentinleguennec Apr 20, 2018
16f017b
Fixing formatting
luigi-agosti Apr 20, 2018
0a6ef87
Removing change to project.pbxproj
luigi-agosti Apr 20, 2018
57a4b5e
Removing unnecessary change
luigi-agosti Apr 20, 2018
e25a56d
Update of version and changelog
luigi-agosti Apr 20, 2018
6c9967d
Merge remote-tracking branch 'upstream/master' into tengio_master
luigi-agosti Apr 20, 2018
08b5884
Camera Plugin: Fixed some PR comments. Prevent plugin to overwrite fi…
quentinleguennec Apr 25, 2018
c9de84c
PR changes for iOS
holykou Apr 25, 2018
2bf1cbc
Merge pull request #7 from holykou/master
quentinleguennec Apr 27, 2018
06c95ad
Fixed formating.
quentinleguennec Apr 27, 2018
b0cbcec
Removed changes to project.pbxproj
luigi-agosti Apr 29, 2018
674151d
Removing changes to gitignore
luigi-agosti Apr 29, 2018
9d196bf
Removing app.flx
luigi-agosti Apr 29, 2018
5bbad3b
Fix issue on ios preventing dart to see the start of the recording
luigi-agosti May 1, 2018
765e4b1
Merge pull request #8 from luigi-agosti/master
holykou May 1, 2018
d52e551
Video streaming freeze bug fix.
holykou May 2, 2018
7b5bced
Matching Android implementation of init.
holykou May 2, 2018
6abd59c
Merge pull request #9 from holykou/master
luigi-agosti May 2, 2018
50d4717
Fixing formatter
luigi-agosti May 2, 2018
bef38e6
Merge remote-tracking branch 'google/master'
luigi-agosti May 2, 2018
3916192
PR changes iOS (#10)
holykou May 3, 2018
82c42d1
Fixed some PR suggestions.
quentinleguennec May 3, 2018
961c787
Fixed issues when trying to record or take several pictures at the sa…
quentinleguennec May 8, 2018
e6ce178
Improved async flow for IOS issue with empty video preview.
quentinleguennec May 8, 2018
60c4854
Merge remote-tracking branch 'origin/master'
quentinleguennec May 8, 2018
1f78d3f
Redo pr deleted by mistake (#12)
quentinleguennec May 10, 2018
226f553
Merge remote-tracking branch 'origin/master'
quentinleguennec May 15, 2018
1f81829
Increased video_player version for example app. Added authors.
quentinleguennec May 15, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions packages/camera/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
## 0.2.0

* Added support for video recording.
* Changed the example app to add video recording.

A lot of **breaking changes** in this version:

Getter changes:
- Removed `isStarted`
- Renamed `initialized` to `isInitialized`
- Added `isRecordingVideo`

Method changes:
- Renamed `capture` to `takePicture`
- Removed `start` (the preview starts automatically when `initialize` is called)
- Added `startVideoRecording(String filePath)`
- Removed `stop` (the preview stops automatically when `dispose` is called)
- Added `stopVideoRecording`

## 0.1.2

* Fix Dart 2 runtime errors.
Expand Down
7 changes: 6 additions & 1 deletion packages/camera/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,18 @@ First, add `camera` as a [dependency in your pubspec.yaml file](https://flutter.

### iOS

Add a row to the `ios/Runner/Info.plist` of your app with the key `Privacy - Camera Usage Description` and a usage description.
Add two rows to the `ios/Runner/Info.plist`:

* one with the key `Privacy - Camera Usage Description` and a usage description.
* and one with the key `Privacy - Microphone Usage Description` and a usage description.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if the user never records video, will the microphone permission still be needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just chiming in here: IIRC, if the iOS app released to App Store contains any code that contains calls to, lets say Location APIs, there has to be keys present in Info.plist for that. Otherwise the app won't go through Apple's review. This is true even though the code calling that Location API is never executed - the mere existence of that call is enough.

So, if recording videos requires an Info.plist key, that has to be present for the app for it to pass Apple's review. Even though the "record video" code path is never called.

The app will still compile though, but will get stuck in the app review.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The permission is only requested when the user begins recording the first video. The user can take photos without granting this permission.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


Or in text format add the key:

```xml
<key>NSCameraUsageDescription</key>
<string>Can I use the camera please?</string>
<key>NSMicrophoneUsageDescription</key>
<string>Can I use the mic please?</string>
```

### Android
Expand Down
1 change: 1 addition & 0 deletions packages/camera/android/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="io.flutter.plugins.camera">
<uses-permission android:name="android.permission.CAMERA"/>
<uses-permission android:name="android.permission.RECORD_AUDIO"/>
</manifest>
Loading