This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
Camera plugin first working version (IOS and Android). #458
Merged
Merged
Changes from all commits
Commits
Show all changes
86 commits
Select commit
Hold shift + click to select a range
a75185e
UI changes + adding dummy video button
nisdis 137fe81
Added dummy Method call video() , with Hello World reply from iOS and…
nisdis 5420d9b
UI changes
nisdis 9fe57d0
Addition of some android MediaRecorder code
nisdis 2db3927
Video recording enabled and running on Android with some bugs
nisdis 2ef3348
Android: fixed bug that crashes app when switching cameras. Also chan…
nisdis 13aea61
Android: fixed bug that crashes app when switching cameras. Also chan…
nisdis c1957cd
added comments and improved readability
nisdis f556d75
Updated GUIDE.md
nisdis dec4b19
Updated GUIDE.md
nisdis a1b41db
Updated GUIDE.md
nisdis 006e0c5
Working code with iOS capture
nisdis 6f3de6a
Working code with iOS capture
nisdis 53b7873
Added comments and cleared unwanted code
nisdis 4cdfd22
Video fix back to preview on iOS after capture is completed
nisdis 4c1e76e
few changes plus rebase with master flutter/plugins repo
nisdis 9d4614e
Addition of some android MediaRecorder code
nisdis f4fe896
added comments and improved readability
nisdis 5fa0086
Big refactoring for the Dart and Android camera plugin. Handles error…
quentinleguennec 2c089d9
Removed some auto-generated flutter logs. Fixed bugs in Android camer…
quentinleguennec dd75acc
Changes to the dart code to enable start/stop on iOS, now saves in do…
nisdis 216513a
Adding description for the missing required permission description se…
luigi-agosti e30acd2
Merge remote-tracking branch 'upstream/master' into camera-dev
luigi-agosti 465de48
Pr Fixes for bundle identifier in the example
luigi-agosti c5cb876
Removing commented code
luigi-agosti 3798a0f
Removed start stop on flutter iOS and dummy calls on Android. Fixed p…
nisdis 904cb8d
Merge branch 'camera-dev' of https://github.com/Tengio/plugins into c…
nisdis bde0f22
Fixing android camera permission crash
luigi-agosti 3ea435a
Merged upstream changes
luigi-agosti 97334a9
Reformatting and fixing pr issues
luigi-agosti e7458c7
CameraPlugin: Refactored error for event sink and removed debug logs.
quentinleguennec 07d3e44
CameraPlugin: Refactored some names. Added documentation for some fun…
quentinleguennec 383c1c3
Camera Plugin: Removed some unused code.
quentinleguennec e7f52e8
Reformatting code
luigi-agosti f71354e
Removing changes to xcode files, Fixing format of the android manifest
luigi-agosti 7e63373
Removing unused persmission
luigi-agosti e88abeb
Removing intl and fixing pr issue
luigi-agosti 7d20380
Add video preview to example
sigurdm d108be1
Remove debug prints
sigurdm 8595213
Merge pull request #3 from sigurdm/video_preview
luigi-agosti cfa239d
Camera Plugin: various fixes based on PR comments.
quentinleguennec b182cc9
Camera Plugin: ran text formating.
quentinleguennec 2be165e
Changes as suggested by the PR review.
holykou ee17048
Remove Message codec
holykou 5d791cf
Removed file sharing key
holykou 96011a4
EventSink syntax changed
holykou 395c829
Error description key updated
holykou ecdbee2
Dart auto format
holykou aaa75ea
Camera Plugin: Refactored UI code of example app and improved it a li…
quentinleguennec 9dfbb34
Merge pull request #4 from holykou/master
quentinleguennec d28a5f8
Merge pull request #5 from Tengio/ui-improvement
quentinleguennec 47744a1
Camera Plugin: Replaced 'openCamera' with 'initialize' and 'closeCame…
quentinleguennec 3acf493
Fixing aspect ratio for the video preview
luigi-agosti 4222b58
Merge remote-tracking branch 'origin/master'
quentinleguennec 4e0b8bd
PR changes for iOS.
holykou 0c0597d
Crash prevention for AVAssetwriter
holykou 14a09c2
Changed error description
holykou e759c42
Merge pull request #6 from holykou/master
luigi-agosti 2762562
Camera Plugin: Fixed a few PR comments.
quentinleguennec 16f017b
Fixing formatting
luigi-agosti 0a6ef87
Removing change to project.pbxproj
luigi-agosti 57a4b5e
Removing unnecessary change
luigi-agosti e25a56d
Update of version and changelog
luigi-agosti 6c9967d
Merge remote-tracking branch 'upstream/master' into tengio_master
luigi-agosti 08b5884
Camera Plugin: Fixed some PR comments. Prevent plugin to overwrite fi…
quentinleguennec c9de84c
PR changes for iOS
holykou 2bf1cbc
Merge pull request #7 from holykou/master
quentinleguennec 06c95ad
Fixed formating.
quentinleguennec b0cbcec
Removed changes to project.pbxproj
luigi-agosti 674151d
Removing changes to gitignore
luigi-agosti 9d196bf
Removing app.flx
luigi-agosti 5bbad3b
Fix issue on ios preventing dart to see the start of the recording
luigi-agosti 765e4b1
Merge pull request #8 from luigi-agosti/master
holykou d52e551
Video streaming freeze bug fix.
holykou 7b5bced
Matching Android implementation of init.
holykou 6abd59c
Merge pull request #9 from holykou/master
luigi-agosti 50d4717
Fixing formatter
luigi-agosti bef38e6
Merge remote-tracking branch 'google/master'
luigi-agosti 3916192
PR changes iOS (#10)
holykou 82c42d1
Fixed some PR suggestions.
quentinleguennec 961c787
Fixed issues when trying to record or take several pictures at the sa…
quentinleguennec e6ce178
Improved async flow for IOS issue with empty video preview.
quentinleguennec 60c4854
Merge remote-tracking branch 'origin/master'
quentinleguennec 1f78d3f
Redo pr deleted by mistake (#12)
quentinleguennec 226f553
Merge remote-tracking branch 'origin/master'
quentinleguennec 1f81829
Increased video_player version for example app. Added authors.
quentinleguennec File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| package="io.flutter.plugins.camera"> | ||
| <uses-permission android:name="android.permission.CAMERA"/> | ||
| <uses-permission android:name="android.permission.RECORD_AUDIO"/> | ||
| </manifest> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if the user never records video, will the microphone permission still be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just chiming in here: IIRC, if the iOS app released to App Store contains any code that contains calls to, lets say Location APIs, there has to be keys present in Info.plist for that. Otherwise the app won't go through Apple's review. This is true even though the code calling that Location API is never executed - the mere existence of that call is enough.
So, if recording videos requires an Info.plist key, that has to be present for the app for it to pass Apple's review. Even though the "record video" code path is never called.
The app will still compile though, but will get stuck in the app review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The permission is only requested when the user begins recording the first video. The user can take photos without granting this permission.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!