-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[flutter_plugin_tools] Add a new 'make-deps-path-based' command #4575
Conversation
gaaclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "pathify" is is a bit difficult to grok. I know it's a pain to change in the PR but I think "convert_depenencies_to_relative_paths" would be more clear.
gaaclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code LGTM. I read the change to the yml file first and didn't really understand what was happening until I read through the PR. I have the feeling that we are increasing the complexity more so we should do our best to make sure the documentation / naming is as clear as we can make it.
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "pathify" is is a bit difficult to grok. I know it's a pain to change in the PR but I think "convert_depenencies_to_relative_paths" would be more clear.
I liked pathify, but you're right that clarity is more important than something that tries to be clever.
I went with make-deps-path-based; the important thing is that they are path-based, not that they are relative (I could just have easily have done absolute paths since people don't generally move their repos while testing a PR), and it's significantly shorter than convert-dependencies-to-path-based without sacrificing clarity.
|
I also changed |
…ter#4575) Adds a new command that adds `dependency_overrides` to any packages in the repository that depend on a list of target packages, including an option to target packages that will publish a non-breaking change in a given diff. Adds a new CI step that uses the above in conjunction with a new `--run-on-dirty-packages` to adjust the dependencies of anything in the repository that uses a to-be-published package and then re-run analysis on just those packages. This will allow us to catch in presubmit any changes that are not breaking from a semver standpoint, but will break us due to our strict analysis in CI. Fixes flutter/flutter#89862
…ter#4575) Adds a new command that adds `dependency_overrides` to any packages in the repository that depend on a list of target packages, including an option to target packages that will publish a non-breaking change in a given diff. Adds a new CI step that uses the above in conjunction with a new `--run-on-dirty-packages` to adjust the dependencies of anything in the repository that uses a to-be-published package and then re-run analysis on just those packages. This will allow us to catch in presubmit any changes that are not breaking from a semver standpoint, but will break us due to our strict analysis in CI. Fixes flutter/flutter#89862
Adds a new command that adds
dependency_overridesto any packages in the repository that depend on a list of target packages, including an option to target packages that will publish a non-breaking change in a given diff.Adds a new CI step that uses the above in conjunction with a new
--run-on-dirty-packagesto adjust the dependencies of anything in the repository that uses a to-be-published package and then re-run analysis on just those packages. This will allow us to catch in presubmit any changes that are not breaking from a semver standpoint, but will break us due to our strict analysis in CI.Fixes flutter/flutter#89862
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).