This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Support new onUrlChanged event on iOS. #4510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: webview_flutter
…w_flutter/url_notifications_ios
…w_flutter/url_notifications_ios
…w_flutter/url_notifications_ios
mvanbeusekom
suggested changes
Nov 16, 2021
packages/webview_flutter/webview_flutter_wkwebview/ios/Classes/FLTWKNavigationDelegate.m
Outdated
Show resolved
Hide resolved
Contributor
|
@BeMacized are you still interested in working on this PR? Is there anything you need from anyone? |
Contributor
Author
|
@Hixie Same as in the other PR: We stopped working on this feature due to there being no good way to implement it in the current structure without a breaking change. The changes to the platform interface these PRs depend on that were merged have been reverted. Once #94051 has been resolved I'll be happy to pick it back up again. |
Contributor
|
@BeMacized How about this one? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds iOS support for the new onUrlChanged event added to the platform interface in #4509.
As this PR contains and depends on the changes made to the platform interface in #4509, this PR will remain in draft state until that PR has been successfully merged and the changes have been published.
Relevant issue:
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change.///).