Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci.yaml] Add builders to recipes cq #4306

Merged
fluttergithubbot merged 1 commit into from
Sep 2, 2021
Merged

[ci.yaml] Add builders to recipes cq #4306

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ targets:
recipe: plugins/plugins
timeout: 30
properties:
add_recipes_cq: "true"
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want the string true, not the value true?

Copy link
Author

@CaseyHillers CaseyHillers Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out! I'll add it to the docs.

This is a limitation of yaml files backed by proto (we define properties to be Map<String, String> as there's no Map<String, dynamic> option (granted we could do a JsonString of sorts)

target_file: windows_build_and_platform_tests.yaml
dependencies: >
[
Expand All @@ -50,6 +51,7 @@ targets:
recipe: plugins/plugins
timeout: 30
properties:
add_recipes_cq: "true"
target_file: windows_build_and_platform_tests.yaml
channel: stable
dependencies: >
Expand Down