[video_player] upgraded pigeon to 1.0

[gaaclarke]

change to video_player_platform_interface that must merge first: #4291

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
• I signed the CLA.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I listed at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[gaaclarke]

Locally testing is working on iOS.

[gaaclarke]

@stuartmorgan Am I able to land this update atomically or am I going to have to separate the video_player_platform_interface changes into a separate PR that I land first?

[gaaclarke]

There is one issue with the Android generated code:

/Users/aaclarke/dev/plugins/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java:146: error: incompatible types: Map<Object,Object> cannot be converted to Map<String,String>
      Map<String, String> httpHeaders = arg.getHttpHeaders();
                                                          ^
1 error

Looks like the template parameters didn't get brought over, the generated code has that method returning Map<Object, Object>.

[stuartmorgan-g]

Am I able to land this update atomically or am I going to have to separate the video_player_platform_interface changes into a separate PR that I land first?

The latter; there is no such thing as an atomic change to multiple packages because they have to be published individually. We also have a repo policy against publishing any untested configuration, and it's impossible to have the dependent packages go through CI as they would be published until the dependencies are published.

[stuartmorgan-g]

Use nullable in ObjC method signatures.

[stuartmorgan-g]

Also, why is this method named incorrectly? This isn't Pigeon-generated presumably.

[gaaclarke]

I think you have to use _Nullable since we are passing in a handle to a FlutterError. It's not named incorrectly, I've used @ObjcSelector to make all the selectors backwards compatible with how the code previously worked.

[gaaclarke]

@stuartmorgan This is a WIP. I'll ping you when it's ready. I'm waiting for 1.0 to land before cleaning it up for review.

[gaaclarke]

I've tested the example app locally on android now too and it works.

[stuartmorgan-g]

This will need to be updated to move the platform channel into the implementation, per the new platform channel plan. That's probably best done a precursor PR to move in a copy of the existing implementation, then updating this PR to update that version.

[stuartmorgan-g]

Closing as obsolete (in favor of #4726) since this copy can't be updated without a breaking change.