Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[multi-packages] Migrate packages and examples to AGP 7.0.0 & Gradle 7.0.2 #4253

Closed
TahaTesser wants to merge 2 commits into from
Closed

[multi-packages] Migrate packages and examples to AGP 7.0.0 & Gradle 7.0.2 #4253

TahaTesser wants to merge 2 commits into from

Conversation

@TahaTesser
Copy link
Member

@TahaTesser TahaTesser commented Aug 22, 2021 •
edited
Loading

Fixes flutter/flutter#88666

Based on #4079, I am not sure if this requires tests but let me know if it does

FYI, keeping this PR as a draft until flutter/flutter#87649 is merged. I think it will be better if Flutter migration is completed before this PR is merged

Todo

  • Update changelog and pubpsec.yaml for all updated packages. (Since this might take a while to be merged if I make any version changes now, it will most likely need to be updated again so I will do this once the PR is ready to be reviewed).

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Aug 22, 2021
@TahaTesser TahaTesser requested a review from blasten August 22, 2021 15:36
@TahaTesser
Copy link
Member Author

TahaTesser commented Aug 22, 2021

This is not breaking change but I still locally tested each package/example migrated, they're all building and running fine on the emulator

@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Aug 23, 2021

It appears that this requires Java 11, which was problematic last time we (inadvertently) tried to switch to it. Fixing issues with Java 11 so that we're not pinned to 1.8 will be necessary as a precursor PR.

/cc @blasten Have you had a chance to look into why 11 doesn't work for us since that tree closure incident?

@TahaTesser TahaTesser changed the title [multi-packages] Migrate packages and examples to AGP 7.0.0 & Gradle 7.0.0 [multi-packages] Migrate packages and examples to AGP 7.0.0 & Gradle 7.0.2 Aug 23, 2021
@TahaTesser TahaTesser mentioned this pull request Aug 26, 2021
Closed
@TahaTesser TahaTesser mentioned this pull request Oct 6, 2021
Closed
@juliansteenbakker juliansteenbakker mentioned this pull request Oct 7, 2021
Closed
@stuartmorgan-g
Copy link
Contributor

stuartmorgan-g commented Nov 16, 2021

Does this pass if you rebase to master? We should have Java 11 in CI now.

@blasten
Copy link

blasten commented Dec 7, 2021

Any updates on this?

@TahaTesser
Copy link
Member Author

TahaTesser commented Dec 7, 2021 •
edited
Loading

@blasten
I will look into this today, thanks!

@TahaTesser
Copy link
Member Author

TahaTesser commented Dec 9, 2021

@blasten @stuartmorgan
If I am not mistaken, looks like some unit tests are failing after the upgrade, any ideas?

@godofredoc godofredoc changed the base branch from master to main January 6, 2022 23:36
@TahaTesser
Copy link
Member Author

TahaTesser commented Jan 21, 2022

Closing this for now as it has become very polluted

@TahaTesser TahaTesser closed this Jan 21, 2022
@TahaTesser TahaTesser deleted the migrate_agp_to_7_0_0 branch January 21, 2022 11:36
@TahaTesser TahaTesser restored the migrate_agp_to_7_0_0 branch January 21, 2022 11:36
@TahaTesser TahaTesser deleted the migrate_agp_to_7_0_0 branch January 21, 2022 11:37
@TahaTesser TahaTesser restored the migrate_agp_to_7_0_0 branch January 21, 2022 11:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@blasten blasten Awaiting requested review from blasten

@gmackall gmackall Awaiting requested review from gmackall gmackall will be requested when the pull request is marked ready for review gmackall is a code owner

@reidbaker reidbaker Awaiting requested review from reidbaker reidbaker will be requested when the pull request is marked ready for review reidbaker is a code owner

@camsim99 camsim99 Awaiting requested review from camsim99 camsim99 will be requested when the pull request is marked ready for review camsim99 is a code owner

@bparrishMines bparrishMines Awaiting requested review from bparrishMines bparrishMines will be requested when the pull request is marked ready for review bparrishMines is a code owner

@tarrinneal tarrinneal Awaiting requested review from tarrinneal tarrinneal will be requested when the pull request is marked ready for review tarrinneal is a code owner

Assignees

No one assigned

Labels

cla: yes p: camera p: espresso p: flutter_plugin_android_lifecycle p: google_maps_flutter p: google_sign_in p: image_picker p: in_app_purchase p: local_auth p: path_provider p: quick_actions p: shared_preferences p: url_launcher p: video_player p: webview_flutter Edits files for a webview_flutter plugin platform-android

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Migrate flutter/plugins packages & examples to Gradle 7.0.2 and AGP 7.0.0

3 participants

@TahaTesser @stuartmorgan-g @blasten