This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] Image picker fix alert #3881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since UIAlertView is deprecated I implemented UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead.
# Conflicts: # packages/image_picker/image_picker/CHANGELOG.md # packages/image_picker/image_picker/ios/Classes/FLTImagePickerPlugin.m
ydag
force-pushed
the
image_picker_fix_alert
branch
from
f421063 to
40decd7
Compare
11 tasks
mvanbeusekom
suggested changes
May 17, 2021
Comment on lines
221
to
222
| if (granted) { | ||
| if (granted) { |
Contributor
There was a problem hiding this comment.
Why the double if (granted) { check?
| library, and taking new pictures with the camera. | ||
| homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker | ||
| version: 0.7.5+1 | ||
| version: 0.7.6 |
Contributor
There was a problem hiding this comment.
Since there's no public API change, it should be 0.7.5+2
| @@ -1,3 +1,6 @@ | |||
| ## 0.7.6 | |||
| * Implement UIAlertController with a preferredStyle of UIAlertControllerStyleAlert since UIAlertView is deprecated. | |||
Contributor
There was a problem hiding this comment.
nit: add back-ticks to indicate the UIAlertController, UIAlertControllerStyleAlert and UIAlertView are code constructs:
Suggested change
| * Implement UIAlertController with a preferredStyle of UIAlertControllerStyleAlert since UIAlertView is deprecated. | |
| * Implement `UIAlertController` with a preferredStyle of `UIAlertControllerStyleAlert` since `UIAlertView` is deprecated. |
mvanbeusekom
approved these changes
May 17, 2021
Contributor
There was a problem hiding this comment.
LGTM, I noticed that @stuartmorgan also wanted to do a review so let's wait for him before we proceed.
I was a bit to quick, the CHANGELOG.md contains the wrong version number.
mvanbeusekom
suggested changes
May 17, 2021
stuartmorgan-g
approved these changes
May 17, 2021
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM once the CHANGELOG is fixed; sorry I forgot about this review last week, I meant to do it after the meeting.
mvanbeusekom
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
11 tasks
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
jolmiracle
pushed a commit
to miracle-as/webview_flutter
that referenced
this pull request
Sep 24, 2021
# Conflicts: # packages/image_picker/image_picker/CHANGELOG.md # packages/image_picker/image_picker/pubspec.yaml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
UIAlertViewis deprecated I implementedUIAlertControllerwith apreferredStyleofUIAlertControllerStyleAlertinstead. I also made some small fixes.Related issues :
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format. See plugin_tool format)[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.