-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[google_sign_in] fix registration links #3859
Conversation
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most users are reading the README from pub.dev, so this needs a version and CHANGELOG update so we can publish it.
Also, we don't usually strictly enforce an 80-char limit for .md files; is there a reason you've reformatted the whole file?
Updated changelog. I was hoping to bump the example, too – before this is published. RE formatting: my editor does that for me. I find it easier to read. I also cleaned out some bits at the bottom. Happy to revert unrelated changes if you prefer. |
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
This pull request is not suitable for automatic merging in its current state.
|
Weird. I have no idea what this means. |
Fixes flutter/flutter#81847