Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider] Update the Linux example template #3774

Closed
robert-ancell wants to merge 1 commit into from
Closed

[path_provider] Update the Linux example template #3774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/path_provider/path_provider_linux/example/linux/flutter/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ add_custom_command(
COMMAND ${CMAKE_COMMAND} -E env
${FLUTTER_TOOL_ENVIRONMENT}
"${FLUTTER_ROOT}/packages/flutter_tools/bin/tool_backend.sh"
linux-x64 ${CMAKE_BUILD_TYPE}
${FLUTTER_TARGET_PLATFORM} ${CMAKE_BUILD_TYPE}
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Mar 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't valid on the stable channel.

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Apr 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robert-ancell Ping; is there a specific issue this was trying to solve? This should auto-migrate for people when building on master.

Copy link
Contributor Author

@robert-ancell robert-ancell May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR was just to test if the CI build failures were due to #3077. I thought this change was trivial but apparently not trivial enough :)

VERBATIM
)
add_custom_target(flutter_assemble DEPENDS
"${FLUTTER_LIBRARY}"
Expand Down
6 changes: 5 additions & 1 deletion ...es/path_provider/path_provider_linux/example/linux/flutter/generated_plugin_registrant.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
// Generated file. Do not edit.
//

// clang-format off

#include "generated_plugin_registrant.h"

void fl_register_plugins(FlPluginRegistry* registry) {}

void fl_register_plugins(FlPluginRegistry* registry) {
}
2 changes: 2 additions & 0 deletions ...ges/path_provider/path_provider_linux/example/linux/flutter/generated_plugin_registrant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
// Generated file. Do not edit.
//

// clang-format off

#ifndef GENERATED_PLUGIN_REGISTRANT_
#define GENERATED_PLUGIN_REGISTRANT_

Expand Down