Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@jason-simmons
Copy link
Member

Copy link

@blasten blasten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blasten
Copy link

blasten commented Feb 23, 2021

I noted this plugin doesn't have Java unit tests wired up, and I'm unsure if a driver test would be able to do the type of mocking that is usually required for stuff like this. @cyanglaz any thoughts?

@cyanglaz
Copy link
Contributor

#3609 includes the same fix and more, I'm going to close this one? @jason-simmons

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[device_info] null safety version crashes for apps that opt into null safety

3 participants