Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@nt4f04uNd
Copy link
Member

@nt4f04uNd nt4f04uNd commented Feb 10, 2021

fixes flutter/flutter#75751

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@nt4f04uNd
Copy link
Member Author

this is wip, as it's blocked by other issues, see flutter/flutter#75751

@nt4f04uNd
Copy link
Member Author

i'm wondering if this is good thing though, because when flutter/flutter#75750 and the camera controller buffer will be exposed as per last bullet in here flutter/flutter#31225, won't be freeze redundant? for example for the use case i listed in the flutter/flutter#75751 it will work faster, but there's a chance that it will be not accurate
so, in general i'm not sure about this change

@nt4f04uNd nt4f04uNd marked this pull request as draft February 10, 2021 01:00
@nt4f04uNd nt4f04uNd changed the title addding freeze parameter to CameraPreview adding freeze parameter to CameraPreview Feb 16, 2021
@nt4f04uNd nt4f04uNd changed the title adding freeze parameter to CameraPreview [camera] adding freeze parameter to CameraPreview Feb 24, 2021
@nt4f04uNd nt4f04uNd marked this pull request as ready for review February 24, 2021 15:03
@nt4f04uNd
Copy link
Member Author

@cyanglaz i guess it's ready for review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[camera] freeze parameter for CameraPreview

1 participant