Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@mit-mit
Copy link
Member

@mit-mit mit-mit commented Oct 29, 2020

Description

Align plugins with new templates, removing unused upper constraint

Related Issues

flutter/flutter#68437

@mit-mit
Copy link
Member Author

mit-mit commented Oct 29, 2020

cc @amirh

Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM in general, wouldn't we need to bump the patch version of each plugin + their CHANGELOG so they become publishable in pub.dev?

Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add CHANGELOG entries and bump the versions?

Co-authored-by: David Iglesias <[email protected]>
@google-cla
Copy link

google-cla bot commented Oct 30, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 30, 2020
@google-cla
Copy link

google-cla bot commented Oct 30, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

@googlebot I fixed it

@google-cla
Copy link

google-cla bot commented Oct 30, 2020

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mit-mit
Copy link
Member Author

mit-mit commented Oct 30, 2020

Abandoning for #3236

@mit-mit mit-mit closed this Oct 30, 2020
@mit-mit mit-mit deleted the upconst branch October 30, 2020 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants