This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[nnbd] Various fixes #3175
Merged
[nnbd] Various fixes #3175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
commented
Oct 21, 2020
blasten
commented
- Cleans up some of the code, so it's consistent.
- Fixes some checks. (hopefully all)
blasten
requested review from
cyanglaz,
iskakaushik,
matthew-carroll,
mehmetf and
mklim
as code owners
blasten
removed request for
cyanglaz,
iskakaushik,
matthew-carroll,
mehmetf and
mklim
added 2 commits
October 20, 2020 18:22
cyanglaz
suggested changes
Oct 21, 2020
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.8 | ||
| // @dart = 2.9 |
Contributor
There was a problem hiding this comment.
connectivity hasn't moved to nnbd yet, my migration PR will handle this. Do you want to maybe revert it for now?
Author
There was a problem hiding this comment.
@dart = 2.9 is non-null safety. @dart = 2.10 enables null safety.
|
|
||
| ## 0.0.1+1 | ||
|
|
||
| * Update README to reflect endorsement. |
Contributor
There was a problem hiding this comment.
Duplicated 0.0.1+1. Looks like a merge error.
Author
|
Some dependency resolution will fail for this patch, but it should be fixed after this patch is merged. This is due to some git dependencies depending on path dependencies. After this change, everything should be fixed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.