Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@gapspt
Copy link

@gapspt gapspt commented Jun 11, 2020

Description

Show the share text in the iOS share preview panel.

Before it just didn't show any preview of the text being shared.

Related Issues

flutter/flutter#55061
flutter/flutter#60470

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

@benPesso
Copy link

Will this also fix flutter/flutter#55061 ?

@gapspt
Copy link
Author

gapspt commented Jul 17, 2020

@benPesso yes, it should. Although I don't think it will fix the "weird ) print", I haven't noticed that happening and have no idea what's that about.

@stuartmorgan-g
Copy link
Contributor

Thanks for the submission! However, we’re currently not accepting non-critical PRs for this plugin, as we hope in time to be able to transition users to the corresponding plugin in the Flutter Community Plus Plugins repository. We encourage you to submit your PR there.

(Note that the issue mentioned above of unconditionally using an iOS 13 framework, rather than weak-linking it, would presumably need to be resolved before it could be landed there as well.)

We apologize for the long delay in triaging this PR. We’re in the process of overhauling our PR triage system to respond much more quickly, as well as working through the backlog.

@stuartmorgan-g stuartmorgan-g added the plus-transition PR closed due to the goal of transitioning to Flutter Community Plus Plugins label Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes p: share plus-transition PR closed due to the goal of transitioning to Flutter Community Plus Plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants