Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented May 7, 2020

Description

This is a necessary precondition for #2544 to pass CI. video_player has a dependency on video_player_web and you can't update video_player's video_player_platform_interface without updating it also for video_player_web.

Related Issues

flutter/flutter#32930

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@gaaclarke gaaclarke requested a review from cyanglaz May 7, 2020 18:26
@gaaclarke gaaclarke changed the title updated video_player_web to use the new video_player_platform_interface [video_player]: updated video_player_web to use the new video_player_platform_interface May 7, 2020
@cyanglaz
Copy link
Contributor

cyanglaz commented May 7, 2020

LGTM assuming CI is going to pass.

@gaaclarke
Copy link
Member Author

Landing on red, the CI error is an artifact of needing to update video_player as well, but I can't update video_player until this one lands. @cyanglaz and I think we've found a way to make this process easier next time.

@gaaclarke gaaclarke merged commit f3ef066 into flutter:master May 7, 2020
stuartmorgan-g pushed a commit to stuartmorgan-g/plugins that referenced this pull request May 11, 2020
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants