Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@zhongwuzw
Copy link
Member

@zhongwuzw zhongwuzw commented Apr 20, 2020

…e than once

Description

Fixes crash when an image in the gallery is tapped more than once

Related Issues

flutter/flutter#55063

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@cyanglaz
Copy link
Contributor

cyanglaz commented Apr 20, 2020

Thank you for the PR!
#2625 seems similar. We are waiting for test to land that PR. If you can help @iheron to add test that'd be great! Or if you can add tests in your PR that'd be good too.

@zhongwuzw
Copy link
Member Author

zhongwuzw commented Apr 21, 2020

@cyanglaz I added one test to simulate the crash when pick image multiple times. I can help #2625 to add their test.

@cyanglaz
Copy link
Contributor

@zhongwuzw This is great! Thanks. The other PR is pretty similar to this one. I'm going to land this, and the other PR might need to rebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants