Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_sign_in/google_sign_in_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.8.4

* Remove all `fakeConstructor$` from the generated facade. JS interop classes do not support non-external constructors.

## 0.8.3+2

* Make the pedantic dev_dependency explicit.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,7 @@ abstract class HttpRequestRejected {
/// HttpRequest supports promises.
/// See Google API Client JavaScript Using Promises https://developers.google.com/api-client-library/javascript/features/promises
@JS("gapi.client.HttpRequestPromise")
class HttpRequestPromise<T> {
// @Ignore
HttpRequestPromise.fakeConstructor$();
}
class HttpRequestPromise<T> {}

@JS("gapi.client.HttpRequestPromise")
abstract class _HttpRequestPromise<T> {
Expand All @@ -374,9 +371,6 @@ extension HttpRequestPromiseExtensions<T> on HttpRequestPromise<T> {
/// An object encapsulating an HTTP request. This object is not instantiated directly, rather it is returned by gapi.client.request.
@JS("gapi.client.HttpRequest")
class HttpRequest<T> extends HttpRequestPromise<T> {
// @Ignore
HttpRequest.fakeConstructor$() : super.fakeConstructor$();

/// Executes the request and runs the supplied callback on response.
external void execute(
dynamic callback(
Expand All @@ -398,9 +392,6 @@ class HttpRequest<T> extends HttpRequestPromise<T> {
/// Represents an HTTP Batch operation. Individual HTTP requests are added with the add method and the batch is executed using execute.
@JS("gapi.client.HttpBatch")
class HttpBatch {
// @Ignore
HttpBatch.fakeConstructor$();

/// Adds a gapi.client.HttpRequest to the batch.
external void add(HttpRequest<dynamic> httpRequest,
[dynamic
Expand Down Expand Up @@ -436,9 +427,6 @@ class HttpBatch {
/// Similar to gapi.client.HttpRequest except this object encapsulates requests generated by registered methods.
@JS("gapi.client.RpcRequest")
class RpcRequest {
// @Ignore
RpcRequest.fakeConstructor$();

/// Executes the request and runs the supplied callback with the response.
external void callback(
void callback(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ import "package:js/js_util.dart" show promiseToFuture;
/// request additional scopes, and sign out from the current account.
@JS("gapi.auth2.GoogleAuth")
class GoogleAuth {
// @Ignore
GoogleAuth.fakeConstructor$();
external IsSignedIn get isSignedIn;
external set isSignedIn(IsSignedIn v);
external CurrentUser get currentUser;
Expand Down Expand Up @@ -212,8 +210,6 @@ abstract class ClientConfig {

@JS("gapi.auth2.SigninOptionsBuilder")
class SigninOptionsBuilder {
// @Ignore
SigninOptionsBuilder.fakeConstructor$();
external dynamic setAppPackageName(String name);
external dynamic setFetchBasicProfile(bool fetch);
external dynamic setPrompt(String prompt);
Expand Down
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_web/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_sign_in_web
description: Flutter plugin for Google Sign-In, a secure authentication system
for signing in with a Google account on Android, iOS and Web.
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_web
version: 0.8.3+2
version: 0.8.4

flutter:
plugin:
Expand Down