Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@cylyl
Copy link
Contributor

@cylyl cylyl commented Mar 6, 2020

Description

A common platform interface for the google_maps_flutter plugin.

This interface allows platform-specific implementations of the google_maps_flutter plugin, as well as the plugin itself, to ensure they are supporting the same interface.

Related Issues

flutter/flutter#45292

Checklist

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@sanekyy
Copy link
Contributor

sanekyy commented Mar 7, 2020

Hello @cylyl. Thank you for your work. Your PR named as "Google maps flutter web support" but in PR description you say just about platform interface. All web plugin methods throws UnimplementedError. Is this PR in progress and not ready to review?

@cylyl
Copy link
Contributor Author

cylyl commented Mar 7, 2020

Hi @sanekyy, the interface package is ready, but the some implementation not yet ready( google_maps_flutter_web). I will continue work on it.

@cylyl cylyl closed this Mar 7, 2020
@ditman
Copy link
Member

ditman commented Mar 18, 2020

@cylyl I've been working on this for a while, I can help you land the platform interface and the web version if you want.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants