This repository was archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[path_provider] Endorse macOS implementation #2566
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
807fbb4
Add dart file
franciscojma86 4748861
Rename file
franciscojma86 c40e813
add interface, rename files, add methods to class
franciscojma86 b049781
Add to method channel, not done
franciscojma86 7543c0c
Add dart file
franciscojma86 d4f1ba5
Rename file
franciscojma86 02b038a
Adds method channel test
franciscojma86 678dd5d
Remove prints
franciscojma86 d88af02
Fix imports and version
franciscojma86 70cffb0
Format and commentas
franciscojma86 9085967
Space
franciscojma86 290e166
Rename apis to path and provide only the string from the platform
franciscojma86 fcd271d
Add test and remove null
franciscojma86 0d7dbbd
Format
franciscojma86 8d9219a
Add export
franciscojma86 ee5bebb
Add imports
franciscojma86 2b1bbd9
Completed apis
franciscojma86 ea5904c
Fix and works
franciscojma86 689ac16
Improve tests
franciscojma86 7f7d351
Remove asyncs
franciscojma86 cdb863a
Add imports
franciscojma86 83fe162
Completed apis
franciscojma86 42cfa09
Fix and works
franciscojma86 90de093
Update version
franciscojma86 cdec1cb
Finish test
franciscojma86 1a22d7f
Merge branch 'path-implement' of github.com:franciscojma86/plugins in…
franciscojma86 c4e5c2e
Merge branch 'master' into path-implement
franciscojma86 d5355ad
Make results per test
franciscojma86 5550c74
Fix
franciscojma86 e544828
Add dependency
franciscojma86 6eba5a6
Merge branch 'master' into path-implement
franciscojma86 3098362
Fix typo nad enum
franciscojma86 c482f3c
Merge branch 'master' into path-implement
franciscojma86 d0afe4d
Change interface version
franciscojma86 effd3b4
Endorse
franciscojma86 f939f85
Update version
franciscojma86 e256c72
Add no-op folder
franciscojma86 d03024e
Merge branch 'master' into path-endorse
franciscojma86 074b8d4
Missing files
franciscojma86 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| ## 1.6.4 | ||
|
|
||
| * Endorsed macOS implementation. | ||
|
|
||
| ## 1.6.3 | ||
|
|
||
| * Use `path_provider_platform_interface` in core plugin. | ||
|
|
||
10 changes: 10 additions & 0 deletions
10
...ges/path_provider/path_provider/example/macos/Runner.xcworkspace/contents.xcworkspacedata
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 22 additions & 0 deletions
22
packages/path_provider/path_provider/macos/path_provider.podspec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # | ||
| # To learn more about a Podspec see http://guides.cocoapods.org/syntax/podspec.html | ||
| # | ||
| Pod::Spec.new do |s| | ||
| s.name = 'path_provider' | ||
| s.version = '0.0.1' | ||
| s.summary = 'No-op implementation of the macos path_provider to avoid build issues on macos' | ||
| s.description = <<-DESC | ||
| No-op implementation of the path_provider plugin to avoid build issues on macos. | ||
| https://github.com/flutter/flutter/issues/46618 | ||
| DESC | ||
| s.homepage = 'https://github.com/flutter/plugins/tree/master/packages/path_provider' | ||
| s.license = { :file => '../LICENSE' } | ||
| s.author = { 'Flutter Team' => '[email protected]' } | ||
| s.source = { :path => '.' } | ||
| s.source_files = 'Classes/**/*' | ||
| s.public_header_files = 'Classes/**/*.h' | ||
|
|
||
| s.platform = :osx | ||
| s.osx.deployment_target = '10.11' | ||
| end | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need the plugin class here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't #2569