Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 5.4.3

* Fixed the launchUniversalLinkIos method.

## 5.4.2

* Make the pedantic dev_dependency explicit.
Expand Down
6 changes: 3 additions & 3 deletions packages/url_launcher/url_launcher/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -91,15 +91,15 @@ class _MyHomePageState extends State<MyHomePage> {
}

Future<void> _launchUniversalLinkIos(String url) async {
if (await canLaunch('https://youtube.com')) {
if (await canLaunch(url)) {
final bool nativeAppLaunchSucceeded = await launch(
'https://youtube.com',
url,
forceSafariVC: false,
universalLinksOnly: true,
);
if (!nativeAppLaunchSucceeded) {
await launch(
'https://youtube.com',
url,
forceSafariVC: true,
);
}
Expand Down
2 changes: 2 additions & 0 deletions packages/url_launcher/url_launcher/example/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ dev_dependencies:
flutter_driver:
sdk: flutter
pedantic: ^1.8.0
mockito: ^4.1.1
plugin_platform_interface: ^1.0.0

flutter:
uses-material-design: true
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
import 'package:flutter_test/flutter_test.dart';
import 'package:flutter/material.dart';
import 'package:mockito/mockito.dart';
import 'package:plugin_platform_interface/plugin_platform_interface.dart';
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';
import 'package:url_launcher_example/main.dart';

void main() {
final MockUrlLauncher mock = MockUrlLauncher();
UrlLauncherPlatform.instance = mock;

testWidgets('Can open URLs', (WidgetTester tester) async {
await tester.pumpWidget(MyApp());
const String defaultUrl = 'https://www.cylog.org/headers/';
when(mock.canLaunch(defaultUrl)).thenAnswer((_) => Future.value(true));
const Map<String, String> defaultHeaders = {
'my_header_key': 'my_header_value'
};
verifyNever(mock.launch(defaultUrl,
useSafariVC: false,
useWebView: false,
enableDomStorage: false,
enableJavaScript: false,
universalLinksOnly: false,
headers: defaultHeaders));

Finder browserlaunchBtn =
find.widgetWithText(RaisedButton, 'Launch in browser');
expect(browserlaunchBtn, findsOneWidget);
await tester.tap(browserlaunchBtn);

verify(mock.launch(defaultUrl,
useSafariVC: false,
useWebView: false,
enableDomStorage: false,
enableJavaScript: false,
universalLinksOnly: false,
headers: defaultHeaders))
.called(1);
});
}

class MockUrlLauncher extends Mock
with MockPlatformInterfaceMixin
implements UrlLauncherPlatform {}
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: url_launcher
description: Flutter plugin for launching a URL on Android and iOS. Supports
web, phone, SMS, and email schemes.
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
version: 5.4.2
version: 5.4.3

flutter:
plugin:
Expand Down
4 changes: 4 additions & 0 deletions packages/url_launcher/url_launcher_macos/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# 0.0.1+5

* Fixed the launchUniversalLinkIos method.

# 0.0.1+4

* Make the pedantic dev_dependency explicit.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,15 @@ class _MyHomePageState extends State<MyHomePage> {
}

Future<void> _launchUniversalLinkIos(String url) async {
if (await canLaunch('https://youtube.com')) {
if (await canLaunch(url)) {
final bool nativeAppLaunchSucceeded = await launch(
'https://youtube.com',
url,
forceSafariVC: false,
universalLinksOnly: true,
);
if (!nativeAppLaunchSucceeded) {
await launch(
'https://youtube.com',
url,
forceSafariVC: true,
);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/url_launcher/url_launcher_macos/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: url_launcher_macos
description: macOS implementation of the url_launcher plugin.
version: 0.0.1+4
version: 0.0.1+5
homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_macos

flutter:
Expand Down