Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_sign_in] Add new Oauth scope methods to google_sign_in_platform_interface. #2547

Merged
cyanglaz merged 12 commits into from
Mar 11, 2020
Merged

[google_sign_in] Add new Oauth scope methods to google_sign_in_platform_interface. #2547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
77c5d95
Add two new scope handling methods to platform_interface.
emerssso Feb 10, 2020
4d20016
Update changelog and version for google_sign_in_platform_interface.
emerssso Feb 10, 2020
00fbc7e
Make test formatting consistent.
emerssso Feb 10, 2020
43407b1
Fix formatting.
emerssso Feb 21, 2020
cd919c2
Convert reqeustScope to allow multiple scopes requested at once.
emerssso Feb 27, 2020
e9af63f
Allow multiple scope grants to be checked at once.
emerssso Feb 28, 2020
a3b635a
Make pluralization of 'scopes' consistent.
emerssso Feb 28, 2020
f8b4628
Receive result as List<dynamic> before converting to List<String>.
emerssso Feb 28, 2020
379a920
Handle null result for missing scopes.
emerssso Feb 28, 2020
f37f53d
Remove listMissingScopes.
emerssso Feb 28, 2020
a01fac4
Add link to scope list in dartdoc.
emerssso Mar 5, 2020
02fdaa7
Fix dartdoc formatting.
emerssso Mar 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.1.0

* Add hasRequestedScope method to determine if an Oauth scope has been granted.
* Add requestScope Method to request new Oauth scopes be granted by the user.

## 1.0.4

* Make the pedantic dev_dependency explicit.
Expand Down
8 changes: 8 additions & 0 deletions ...ogle_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,4 +121,12 @@ abstract class GoogleSignInPlatform {
Future<void> clearAuthCache({@required String token}) async {
throw UnimplementedError('clearAuthCache() has not been implemented.');
}

/// Requests the user grants additional Oauth [scopes].
///
/// Scopes should come from the full list
/// [here](https://developers.google.com/identity/protocols/googlescopes).
Future<bool> requestScopes(List<String> scopes) async {
Copy link
Contributor

@cyanglaz cyanglaz Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what can be the values of the scopes? Maybe we should either make an enum or have some concrete list of what the values can be.

Copy link
Member

@ditman ditman Mar 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cyanglaz There's a TON of auth scopes, here's the list: https://developers.google.com/identity/protocols/googlescopes (each API that you want to use has its own set of scopes). In Java for example, each API may provide its set of scopes, and not the core plugin.

Copy link
Contributor

@cyanglaz cyanglaz Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add this link to the dartdoc?

Copy link
Member

@ditman ditman Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good point! It can probably be added to the README.md.

Copy link
Contributor Author

@emerssso emerssso Mar 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a link in the dartdoc. Looks like this is already mentioned in the README.md here.

throw UnimplementedError('requestScopes() has not been implmented.');
}
}
8 changes: 8 additions & 0 deletions ...ogle_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,12 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform {
<String, String>{'token': token},
);
}

@override
Future<bool> requestScopes(List<String> scopes) {
return channel.invokeMethod<bool>(
'requestScopes',
<String, List<String>>{'scopes': scopes},
);
}
}
2 changes: 1 addition & 1 deletion packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: A common platform interface for the google_sign_in plugin.
homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_platform_interface
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 1.0.4
version: 1.1.0

dependencies:
flutter:
Expand Down
5 changes: 5 additions & 0 deletions ...le_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,11 @@ void main() {
}: isMethodCall('clearAuthCache', arguments: <String, dynamic>{
'token': 'abc',
}),
() {
googleSignIn.requestScopes(['newScope', 'anotherScope']);
}: isMethodCall('requestScopes', arguments: <String, dynamic>{
'scopes': ['newScope', 'anotherScope'],
}),
googleSignIn.signOut: isMethodCall('signOut', arguments: null),
googleSignIn.disconnect: isMethodCall('disconnect', arguments: null),
googleSignIn.isSignedIn: isMethodCall('isSignedIn', arguments: null),
Expand Down