Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Description

A previous PR incorrectly added *.xcworkspace to the repository's
top-level .gitignore, causing all examples added after that
point--notably the addition of macOS to the examples--to incorrectly
omit the necessary Runner.xcworkspace.

This removes the incorrect .gitignore entry, and adds the missing
workspaces.

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

A previous PR incorrectly added *.xcworkspace to the repository's
top-level .gitignore, causing all examples added after that
point--notably the addition of macOS to the examples--to incorrectly
omit the necessary Runner.xcworkspace.

This removes the incorrect .gitignore entry, and adds the missing
workspaces.
Copy link
Contributor

@amirh amirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g
Copy link
Contributor Author

Since this macOS-target-only change can't possibly have regressed signing device builds for iOS, and this PR fixes known breakage, I'm going to land despite the one failed presubmit check (which I assume is an agent issue).

@stuartmorgan-g stuartmorgan-g merged commit 5f03826 into flutter:master Jan 16, 2020
@stuartmorgan-g stuartmorgan-g deleted the macos-example-workspaces branch January 16, 2020 08:20
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
A previous PR incorrectly added *.xcworkspace to the repository's
top-level .gitignore, causing all examples added after that
point--notably the addition of macOS to the examples--to incorrectly
omit the necessary Runner.xcworkspace.

This removes the incorrect .gitignore entry, and adds the missing
workspaces.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants