This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Bump roboelectric version #2475
Merged
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! |
Contributor
|
Though I hope that major version bump doesn't imply a breaking change that breaks our tests... |
Contributor
Author
|
It it does we can try to find another version. This seemed to work locally but I'm not sure I actually ran the tests :) |
Contributor
|
In presubmit we trust... today |
Contributor
Author
|
/cc @cyanglaz fyi |
Contributor
Author
|
This spits out a bunch of deprecation warnings like
|
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI
Fixes flutter/flutter#48943
Maven has changed their access policies as of today: https://support.sonatype.com/hc/en-us/articles/360041287334
The old version of roboelectric is refering to http resources in its POM. This one is good.
@amirh