Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] not muted video sound when mute control of device is muted #2457

Closed
jerryzhoujw wants to merge 2 commits into from
Closed

[video_player] not muted video sound when mute control of device is muted #2457

jerryzhoujw wants to merge 2 commits into from

Conversation

@jerryzhoujw
Copy link
Contributor

@jerryzhoujw jerryzhoujw commented Jan 10, 2020

@cbenhagen
Copy link
Contributor

cbenhagen commented Jan 10, 2020

This is already done on plugin init. flutter/flutter#47524 tracks this issue and #2434 fixes it.

@otopba
Copy link
Contributor

otopba commented Jan 10, 2020

Also this is about AVAudioSession
#1174

@jerryzhoujw
Copy link
Contributor Author

jerryzhoujw commented Jan 10, 2020

Thank you for mention me about that. @cbenhagen @otopba

I simply query issue by [video_player], and didn't see any obvious issue title mentioned mute, so I create this.

Maybe I need read more details in every related issues.

I'll leave this PR open till your mentioned PR get merged, after that I will close this.

Thanks.

@cbenhagen
Copy link
Contributor

cbenhagen commented Jan 28, 2020

#2434 has been merged. Can this PR be closed?

@jerryzhoujw
Copy link
Contributor Author

jerryzhoujw commented Jan 30, 2020

@cbenhagen sure.

@jerryzhoujw jerryzhoujw deleted the dev/not_mute_video_when_mute_control_of_devic_is_muted branch January 30, 2020 12:30
@jerryzhoujw jerryzhoujw restored the dev/not_mute_video_when_mute_control_of_devic_is_muted branch January 31, 2020 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jerryzhoujw @cbenhagen @otopba @googlebot