Revert "[url_launcher] fix: Link widget Tab traversal" #9980
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 2d651b2.
stuartmorgan-g
requested review from
bparrishMines,
pedromassango,
chunhtai and
tarrinneal
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts a previous change that introduced a MergeSemantics widget to the web Link widget. According to the description, the original change broke the build tree. The changes in this PR correctly remove the feature, its associated integration test, the version bump in pubspec.yaml, and the corresponding CHANGELOG.md entry. The revert appears to be complete and correct.
stuartmorgan-g
added
the
emergency
|
Detected the If you add the The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue". |
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 10, 2025
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 10, 2025
flutter/packages@2d651b2...03598e7 2025-09-10 [email protected] [url_launcher] Temporarily restore Android 21 support (flutter/packages#9986) 2025-09-10 [email protected] Roll Flutter from 973320c to a082096 (17 revisions) (flutter/packages#9983) 2025-09-09 [email protected] [various] Scrub pre-Android-API <24 code (flutter/packages#9851) 2025-09-09 [email protected] [google_sign_in] Add a platform interface method to clear auth tokens (flutter/packages#9929) 2025-09-09 [email protected] Revert "[url_launcher] fix: Link widget Tab traversal" (flutter/packages#9980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mboetger
pushed a commit
to mboetger/flutter
that referenced
this pull request
Sep 18, 2025
…r#175185) flutter/packages@2d651b2...03598e7 2025-09-10 [email protected] [url_launcher] Temporarily restore Android 21 support (flutter/packages#9986) 2025-09-10 [email protected] Roll Flutter from 973320c to a082096 (17 revisions) (flutter/packages#9983) 2025-09-09 [email protected] [various] Scrub pre-Android-API <24 code (flutter/packages#9851) 2025-09-09 [email protected] [google_sign_in] Add a platform interface method to clear auth tokens (flutter/packages#9929) 2025-09-09 [email protected] Revert "[url_launcher] fix: Link widget Tab traversal" (flutter/packages#9980) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9815
The tree is now broken in exactly the way the presubmits for that PR were broken; it should not have landed.