[all_packages] Bump compileSdk version to 35

[camsim99]

Bumps all_packages app to build with compileSdk version 35. Then,

• Updates the Gradle and AGP versions to support this new Android SDK version
• Refactors the legacy all_packages CI build target such that the regular all_packages CI build targets (master, stable) will build both the modern all_packages app and the legacy version with the same JDK 17 version, since the legacy version now also requires it (example successful builds: master, stable)
• Updates legacy all_packages app README.md to more accurately describe how the app was transformed since its creation

Prompted by #8414.

Pre-Review Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene page, which explains my responsibilities.
• I read and followed the relevant style guides and ran the auto-formatter.
• I signed the CLA.
• The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
• I linked to at least one issue that this PR fixes in the description above.
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under¹.
• I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under¹.
• I updated/added any relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or I have commented below to indicate which test exemption this PR falls under¹.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩² ↩³

[camsim99]

Getting the failure:

* What went wrong:
An exception occurred applying plugin request [id: 'com.android.application']
> Failed to apply plugin 'com.android.internal.application'.
   > Android Gradle plugin requires Java 17 to run. You are currently using Java 11.
      Your current JDK is located in /b/s/w/ir/cache/java
      You can try some of the following options:
       - changing the IDE settings.
       - changing the JAVA_HOME environment variable.
       - changing `org.gradle.java.home` in `gradle.properties`.
...

┌─ Flutter Fix ───────────────────────────────────────────────────────────────────────┐
│ [!] Android Gradle plugin requires Java 17 to run. You are currently using Java 11. │
│                                                                                     │
│ To fix this issue, try updating to the latest Android SDK and Android Studio on:    │
│ https://developer.android.com/studio/install                                        │
│ If that does not work, you can set the Java version used by Flutter by              │
│ running `flutter config --jdk-dir=“</path/to/jdk>“`                                 │
│                                                                                     │
│ To check the Java version used by Flutter, run `flutter doctor --verbose`           │
└─────────────────────────────────────────────────────────────────────────────────────┘

I assume the build is using Java 11 because all of the plugins have sourceCompatibility, targetCompatibility as Java 11. @stuartmorgan-g is that correct?

[stuartmorgan-g]

build_all_packages_legacy is run on a machine that installs Java 11 because we needed it still; see here and here. You'd need to bump that in the PR.

[camsim99]

@reidbaker following up from sync, sounds like I should revert the changes to the legacy target to ensure we are still testing Java 11 as we (Flutter) still support it!

[reidbaker]

Let me review the pr as is, my gut is that legacy package tests using java11 are still valuable but a pr is better than a verbal description.

No work for you right now

[stuartmorgan-g]

Based on https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8714424714677414961/+/u/Run_package_tests/build_all_packages_for_Android_debug/stdout, if we don't make this change I'll need to exempt google_sign_in from the build-all build for now.

[camsim99]

Getting an odd formatting error; taking a look:

Formatting .kt files...
Running command: "java -jar /b/s/w/ir/x/w/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar ../third_party/packages/flutter_svg/example/android/app/src/main/kotlin/io/flutter/plugins/fluttersvgexample/MainActivity.kt animations/example/android/app/src/main/kotlin/dev/flutter/packages/animations/example/MainActivity.kt camera/camera_android_camerax/android/src/main/java/io/flutter/plugins/camerax/CameraXLibrary.g.kt [...redacted...]
Error: Invalid or corrupt jarfile /b/s/w/ir/x/w/packages/script/tool/bin/ktfmt-0.46-jar-with-dependencies.jar
Failed to format Kotlin files: exit code 1.